fix(SSR): explicitly load KtNavbar as a component #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change in the template of NavBar.vue produced a very hard to trace down bug which caused the navbar to not render in the documentation. Although the source of this bug could not be made out, it seemed to have to do with how nuxt is resolving components. Adding an explicit import of KtNavbar in the file (and therefore not relying on the kotti-ui plugin for nuxt) fixes this. As the file change that triggered this is very unrelated and it would be impossible to see this very unrelated effect in code review, a test was added that should at least stop the very same event to occur Co-Authored-By: Florian Wendelborn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in the template of NavBar.vue produced a very hard to trace down bug which caused the navbar to not render in the documentation. Although the source of this bug could not be made out, it seemed to have to do with how nuxt is resolving components. Adding an explicit import of KtNavbar in the file (and therefore not relying on the kotti-ui plugin for nuxt) fixes this.
As the file change that triggered this is very unrelated and it would be impossible to see this very unrelated effect in code review, a test was added that should at least stop the very same event to occur