command persistence now will purge NextAwaiter state store #92
Conversation
| @@ -520,10 +527,12 @@ export const createMachineRunnerInternal = < | |||
|
|
|||
| emitter.on('next', nva.push) | |||
| emitter.on('failure', nva.fail) | |||
| emitter.on('commandPersisted', nva.purge) | |||
There was a problem hiding this comment.
Ah, this might have been a misunderstanding or I might miss something: my understanding was that
someState.commands().someCommand()should directly purge the awaiter state; I didn’t think that we need to wait until persistence is done.
There was a problem hiding this comment.
I initially thought that too, but then I thought purge should happen only when an event has been published.
When the swarm protocol is linear, this event publishing will be a key to the continuation of it;
there is a higher guarantee that a next-triggering state change will happen, either triggered by the published event in question or a peer reacting to said event.
There was a problem hiding this comment.
Yes, that’s a good point, thanks for the explanation!
| @@ -520,10 +527,12 @@ export const createMachineRunnerInternal = < | |||
|
|
|||
| emitter.on('next', nva.push) | |||
| emitter.on('failure', nva.fail) | |||
| emitter.on('commandPersisted', nva.purge) | |||
There was a problem hiding this comment.
Yes, that’s a good point, thanks for the explanation!
| let nextOrPeekTriggered = false | ||
| const peek = machine.peekNext() | ||
| const next = machine.next() | ||
| Promise.race([peek, next]).finally(() => (nextOrPeekTriggered = true)) |
There was a problem hiding this comment.
same as we discussed yesterday, which is probably in many other tests as well: after this line we need
await Promise.resolve()There was a problem hiding this comment.
Ah yes. await r1.eventRoundtrip.waitAllDone() was below this line; I moved it up, forgetting that it is important down there too.
Kelerchian
force-pushed
the
ada/90-command-call-consumes-nextawaiterstate-state-store
branch
2 times, most recently
from
6e8fd26 to
1d23910
Compare
Kelerchian
force-pushed
the
ada/90-command-call-consumes-nextawaiterstate-state-store
branch
from
1d23910 to
785f4db
Compare
Kelerchian
deleted the
ada/90-command-call-consumes-nextawaiterstate-state-store
branch
No description provided.