Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract Upgrade: 8 PSM contracts #10403

Closed
Chris-Hibbert opened this issue Nov 5, 2024 · 0 comments · Fixed by #10730
Closed

Contract Upgrade: 8 PSM contracts #10403

Chris-Hibbert opened this issue Nov 5, 2024 · 0 comments · Fixed by #10730
Assignees
Labels
contract-upgrade enhancement New feature or request Inter-protocol Overarching Inter Protocol Zoe Contract Contracts within Zoe

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

As mentioned in #8158, we need the ability to restart all vats. This issue is concerned with restarting PSM contracts. (V37-V42, V73, V76)

Description of the Design

The source for the PSM contract is in [psm.js](https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/src/psm/psm.js]. All the current ones are based on the code as of mainNet-1B. psm-upgrade.test.js shows that it's upgradeable.

Create a framework for a proposal to upgrade one or more contracts, and invoke it from upgrade.go. Add tests to a3p-integration.

Security Considerations

The USDT PSM contract is currently holding $300K of USDT.

Scaling Considerations

N/A.

Test Plan

Replicating the tests in psm-upgrade.test.js should be sufficient.

Upgrade Considerations

#7903 has a clean-up for the PSM contract. It should be merged before we do these upgrades.

Let's start by upgrading one of the contracts with a smaller balance, and test it on mainNet, before proceeding gradually to more substantial contracts.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Zoe Contract Contracts within Zoe Inter-protocol Overarching Inter Protocol contract-upgrade labels Nov 5, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this Nov 7, 2024
@mergify mergify bot closed this as completed in #10730 Dec 30, 2024
mergify bot pushed a commit that referenced this issue Dec 30, 2024
closes: #10403

## Description
Adds the upgrade of the psm contracts to upgrade 19. To ensure that this upgrade will succeed, we've also added test coverage in A3P.

### Upgrade Considerations

This PR adds the PSM contract to the list of vat upgrades. The PSM upgrade proposal will upgrade all PSM instances on the chain. We've added A3P tests to ensure that the upgrade is successful and that assets are still in the reserve after the upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request Inter-protocol Overarching Inter Protocol Zoe Contract Contracts within Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants