Auto Update Deployer Address #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Jovonni
force-pushed
the
multichain-u17-with-icq
branch
from
a927fb8 to
220427a
Compare
Jovonni
reviewed
Sep 24, 2024
|
also |
amessbee
force-pushed
the
ms/autoUpdate-deployer-address
branch
from
9e1752f to
c1fabe9
Compare
|
@Jovonni cleaned up! |
Jovonni
approved these changes
Sep 25, 2024
contract/Makefile
Outdated
| ADDR=agoric1vck7hw7wak2y7vv3pnf7am6kmgl7nwgz3ltsla | ||
| # ADDR=agoric125d8s0tamx50gpqdd3m7f5gtkzkcnjs0ehsujr | ||
| # fetch the address of the deployer account from the chain - you may need to adjust this to match your setup | ||
| ADDR=$(kubectl exec -i agoriclocal-genesis-0 -c validator -- agd keys add user1 | jq -r '.address') |
There was a problem hiding this comment.
nice one liner, maybe add $USER or something to the agd keys add user1, as sometimes I do this for "alice", and sometimes for "user1"
WDYT?
There was a problem hiding this comment.
Done.
Also, I added a check to see if a user has already been added - in case one calls make multiple times.
dckc
force-pushed
the
multichain-u17-with-icq
branch
2 times, most recently
from
f09810b to
d3144de
Compare
amessbee
force-pushed
the
ms/autoUpdate-deployer-address
branch
from
880b390 to
8935e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto Update Deployer Address in
contract/Makefile