Resyncing with head fork #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added missing import CoreGraphics where needed. - Added missing import UIKit where needed.
Uploading from GitHub
`class` is better as it allows Swift classes to avoid the NSObject overhead.
Adding a `self.` reference to a instance variable reduced the compile time significantly (over 10x improvement). A single line evaluation of a variable was further broken out into separate steps to reduce the compile time as well.
Fixed value setter on PieChartDataEntry
Reduce build time with minor reference refactor
tutorial link added to readme
Update xcode project to support xcode 9
Conform to macOS api changes in swift 3.2
Fix CombinedChartView not draw markers
Add Swift Package Manager support.
* unwrap optionals * unwrap delegate * unwrap h * remove underscore from local constant * updates from code review * more cleanup * add guard
Swift iOS Demos
added highlightColor parameter for pie charts
Replaced `ChartUtils` methods with `CGSize` extensions
Minor changes to Animator
Minor changes to BubbleChartRenderer logic
* Minor changes to logic in `ViewPortJob` subclasses. * Removed TODOs
Since the framework is entirely Swift, internal properties do not need to be marked as @objc
in favour of the Swift `is`
* `Animator` is now non-optional in `Renderer` types * Fixed merge with master
* `ViewPortHandler` is now non-optional in all, if not most cases * Removed unnecessary `init()`s from `ViewPortHandler` and related * `Renderer` now has a constant `ViewPortHandler` * Pulled latest master * Fixes for PR review Removed extraneous comment Removed extra whitespace * Removed extra new lines
* `ViewPortHandler` is now non-optional in all, if not most cases * Removed unnecessary `init()`s from `ViewPortHandler` and related * `Renderer` now has a constant `ViewPortHandler` * `ChartRenderer`'s must be initialized with a chart * CombinedChartRenderer gets the same treatment * Pulled latest master * Pulled latest master * Removed unnecessary comment * Removed unnecessary whitespace
Removed `isKind(of:)`
Removed @objc from internal properties
Fix turning off drag in X and Y axes separately.
almsot all cases of fileprivate were meant to be private. If there is a need to use fileprivate in the future, it should be considered then. Not now.
for #2745. chart should be weak.
* Fix a bug may cause infinite loop. * Update BarLineChartViewBase.swift put nil check first seems better
…t` (#2993) * Replaced `ChartUtils.Math` in favour of an extension on `FloatingPoint` Increases readability, and in many cases removes a set of parentheses to ensure order of operations. * Moved `normalizedAngled` into `FloatingPoint` extension Improves readability * Fix after merge * Pulled latest master * Renamed deg2rad/rad2deg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.