Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resyncing with head fork #2

Merged
merged 96 commits into from
Dec 12, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
5d4f8ac
Compatibility with swift playgrounds
macteo Apr 6, 2017
409cebf
Added one last missing import CoreGraphics
macteo Apr 7, 2017
8cbdf6d
add example playground
thierryH91200 Apr 15, 2017
629c548
Allow turning off drag in X and Y axis separately.
maciejtrybilo May 5, 2017
1286da0
tutorial link added to readme
May 29, 2017
b0ef524
Added Swift iOS demos
Jul 21, 2017
469b636
.xcodeproj won't add to git
jjatie Jul 21, 2017
26965e1
Replaced unnecessary NSObjectProtocol
Jul 21, 2017
9b1ab68
Fix CombinedChartView not draw markers
Aug 11, 2017
7635f5f
conform to macOS api changes in swift 3.2
ohbargain Aug 14, 2017
80a45c0
Reduce build time with minor reference change
Aug 4, 2017
e23d186
Fixed value setter on PieChartDataEntry
martnst Aug 28, 2017
91aa10f
Merge pull request #2754 from martnst/patch-1
liuxuan30 Aug 29, 2017
69cdd84
Merge pull request #2679 from xinranw/reduce-build-time
liuxuan30 Aug 29, 2017
cf0aa2d
Merge branch 'master' into master
pmairoldi Sep 2, 2017
79b6049
Merge pull request #2484 from annalizhaz/master
pmairoldi Sep 2, 2017
f6525a0
update xcode project for xcode 9
pmairoldi Sep 2, 2017
252a7bc
remove unused Carthage.xcconfig
pmairoldi Sep 3, 2017
225ec3d
remove rvm version to fix travis
pmairoldi Sep 3, 2017
0a01d34
remove watchOS platform
pmairoldi Sep 3, 2017
705d9ad
update travis config to add xcode9
pmairoldi Sep 3, 2017
d300d6d
fix tests by adding tolerance and device ids
pmairoldi Sep 3, 2017
573cd17
Merge pull request #2767 from danielgindi/xcode-9
pmairoldi Sep 3, 2017
765b88e
Delete FrameworkSpec
pmairoldi Sep 3, 2017
d7dc8f0
Merge pull request #2717 from ohbargain/apply_macOS_change
pmairoldi Sep 3, 2017
079dff4
refactor getDataSetByHighlight and entryForHighlight
liuxuan30 Sep 5, 2017
59218f0
refactor CombinedChartView drawMarkers
liuxuan30 Sep 5, 2017
f9eea57
Merge pull request #2702 from xzysun/master
liuxuan30 Sep 5, 2017
f43bc57
refactor code style
liuxuan30 Sep 7, 2017
37cac1a
migrate code to swift 4
pmairoldi Sep 7, 2017
a9e1e70
fix build errors after migration
pmairoldi Sep 7, 2017
131602f
update demos for swift 4
pmairoldi Sep 7, 2017
0cf4ef4
Part I modify All NSAttributedStringKey related methods for Swift 4
liuxuan30 Jun 8, 2017
9dcc5ef
fix charts project file
pmairoldi Sep 7, 2017
19750f7
Merge pull request #2413 from maciejtrybilo/dragXYEnabled
liuxuan30 Sep 7, 2017
5e3ac75
update travis config
pmairoldi Sep 8, 2017
e968e21
release 3.0.3
pmairoldi Sep 8, 2017
983d556
bump version
pmairoldi Sep 8, 2017
4b10e47
Minor refactoring
danielgindi Sep 8, 2017
3c083f3
Fixed axis drag locking (Completes #2413)
danielgindi Sep 8, 2017
70f85f7
Reorganized in preparation of merging Swift Demos
Sep 17, 2017
7fdad5e
Merged all iOS demos to one project with 2 targets
Sep 17, 2017
bb6983e
Clean up
Sep 17, 2017
e47f8c4
Merge pull request #2507 from danielgindi/swift4
liuxuan30 Sep 21, 2017
d953129
Update README.md
liuxuan30 Sep 21, 2017
4053e7c
Bumped pod spec version
mohpor Sep 21, 2017
a891d97
Merge pull request #1 from mohpor/swift4Pod
mohpor Sep 21, 2017
5417160
Merge pull request #2806 from mohpor/master
liuxuan30 Sep 21, 2017
0593be7
add swift 4 version file for cocoapods
pmairoldi Sep 22, 2017
2ccd171
Merge pull request #2335 from macteo/master
pmairoldi Sep 25, 2017
8245f32
Merge pull request #2364 from thierryH91200/master
pmairoldi Sep 25, 2017
ad4d942
duplicated code for set1
liuxuan30 Oct 13, 2017
d7cd7b9
Update LICENSE
sDaniel Oct 16, 2017
655d0be
fix #2890. Turned out it's multiple bar chart but not grouped
liuxuan30 Oct 17, 2017
130d026
Merge pull request #2891 from liuxuan30/2890
liuxuan30 Oct 17, 2017
0a63b74
Merge pull request #2872 from danielgindi/bubble
liuxuan30 Oct 17, 2017
2f887bd
Merge pull request #2629 from jjatie/NSObjectProtocol
pmairoldi Oct 20, 2017
bdbdaa6
Merge pull request #2887 from sDaniel/patch-1
pmairoldi Oct 21, 2017
021d5fb
[modify]
hir-suzuki Nov 2, 2017
37c8a77
Fix turning off drag in X and Y axes separately.
maciejtrybilo Nov 2, 2017
9b9dd68
Add Swift Package Manager support.
Nov 2, 2017
98552bb
Merge pull request #2942 from suzuhiroruri/fix_character_deprecated
liuxuan30 Nov 3, 2017
57c2e11
added highlightColor parameter for pie charts
Nov 6, 2017
0f0bffd
Merged latest master
jjatie Nov 6, 2017
91ca0f9
1. use Launch Screen storyboard and remove launch images for easy ado…
liuxuan30 Nov 7, 2017
f00f9de
update xib to adopt safe area
liuxuan30 Nov 8, 2017
ecba1da
Merge pull request #2967 from danielgindi/iPhoneX
liuxuan30 Nov 8, 2017
a1811c7
Merge pull request #2950 from BrianDoig/master
liuxuan30 Nov 8, 2017
01160fd
Replaced `ChartUtils` methods with `CGSize` extensions
jjatie Nov 13, 2017
3ec4bc1
Merge remote-tracking branch 'upstream/master' into demos
jjatie Nov 14, 2017
b4f84b6
Pulled latest master
jjatie Nov 14, 2017
ee337d7
Minor changes to Animator
jjatie Nov 14, 2017
fc22a27
unwrap optionals (#2698)
russellbstephens Nov 15, 2017
3672219
Merge pull request #2628 from jjatie/demos
pmairoldi Nov 15, 2017
e8fa7ad
clean up demo project
pmairoldi Nov 15, 2017
b27e366
Merge pull request #2961 from pascalherrmann/master
pmairoldi Nov 15, 2017
c37e553
Merge pull request #2995 from jjatie/cgsize-extensions
pmairoldi Nov 15, 2017
50fdd2d
Merge remote-tracking branch 'upstream/master' into animator-cleanup
jjatie Nov 15, 2017
9ebcae0
Minor changes to BubbleChartRenderer logic
jjatie Nov 15, 2017
19e8b00
Merge pull request #3005 from jjatie/animator-cleanup
pmairoldi Nov 17, 2017
3b6eda1
Merge pull request #3010 from jjatie/bubble-chart-renderer-cleanup
pmairoldi Nov 20, 2017
bc40b16
Minor changes to logic in `ViewPortJob` subclasses. (#2992)
jjatie Nov 23, 2017
6869d85
Removed @objc from internal properties
jjatie Nov 23, 2017
c7a1c04
Removed `isKind(of:)`
jjatie Nov 23, 2017
122013e
Animator non nil (#2981)
jjatie Nov 24, 2017
fb02977
View port handler nonnil (#2980)
jjatie Nov 27, 2017
0f74a25
`ChartRenderer`'s must be initialized with a chart (#2982)
jjatie Nov 27, 2017
19da2c0
Merge pull request #3044 from jjatie/iskind-of
liuxuan30 Dec 5, 2017
b87d04e
Merge pull request #3038 from jjatie/internal-drop-objc
liuxuan30 Dec 5, 2017
60829b3
Merge pull request #2949 from maciejtrybilo/master
liuxuan30 Dec 5, 2017
8c9d5f3
fileprivate -> private (#3042)
jjatie Dec 8, 2017
c6faf53
for #2745. chart should be weak.
liuxuan30 Dec 8, 2017
2ff5cb5
Merge pull request #3078 from liuxuan30/2772
liuxuan30 Dec 8, 2017
6fee51c
Fix a bug may cause infinite loop. (#3073)
JyHu Dec 9, 2017
d321093
Minor logic cleanup (#3041)
jjatie Dec 9, 2017
159e0f7
Replaced `ChartUtils.Math` in favour of an extension on `FloatingPoin…
jjatie Dec 11, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .swift-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
4.0
34 changes: 18 additions & 16 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,25 @@
osx_image: xcode8.3
language: objective-c
rvm:
- 2.2
osx_image: xcode9
matrix:
include:
- osx_image: xcode9
env: PLATFORM="iOS"
- osx_image: xcode9
env: PLATFORM="tvOS"
- osx_image: xcode9
env: PLATFORM="macOS"
env:
global:
- LANG=en_US.UTF-8
- secure: HRl5Cg3/LmTJYCSDGtV8Fiqf6OgWXR6C5YkNviOElU9YmcCTvnmE7MCm+gK8hJNIQ2mWCBTlxTC7jJxeYlx0D+JQ6IhRc75B4zXgbtth6HCzlvhWDcBbNU/K+JPDjy2EAoVgvf8Xseq6GqM4WcVg2Pwr9PS3aaH/SKDE6yVoPXRM2wXRAxIdxayqm/RQgG88jAKgg+Ub5DKW/c9NLLbUf/WdY9SgQDJtqeZCMv7G3/IzW34KZgVPsqSrPByzZXbf7KgYkYLQlscH4mcUctk1qxhdCae//zcgUZo/utpXWbPXQqtvDpuqrg9IRvoGxa/D1I7dLSJsVnk4aP7RW18vn4HJ82C2AiEp+lU2TQE9y5lXcGssZVIa5aZNTWL90HVer3Kg6AnHffvdCSZ/UHsMZJFURUXL9fRIlWVGuEDeQOqlV6lUmEtp/BiEdV4D5PuCyT6snsmEwkc51goyqh6uS6XhJyqYEQdxdoybznwp91tVmASsRybppIGHTkcWN5csF4zQt40tEwd8LoqM+bBUo0wxKiKsNsecL4JA+YDYs2saZY9U3s8jAaIon+qDu071fPRaPEvBhYHYDhy4cTvBXibyGUYGHkrgLu0w19wDfHcJKt2In58yOmaCCLNoTGp/ZLNVRyZ8VDlj/NdJ2dWpMsL2Aj7OxU065kCL2FlvuRU=
matrix:
- PLATFORM="iOS"
- PLATFORM="tvOS"
- PLATFORM="macOS"
- LANG=en_US.UTF-8
- secure: HRl5Cg3/LmTJYCSDGtV8Fiqf6OgWXR6C5YkNviOElU9YmcCTvnmE7MCm+gK8hJNIQ2mWCBTlxTC7jJxeYlx0D+JQ6IhRc75B4zXgbtth6HCzlvhWDcBbNU/K+JPDjy2EAoVgvf8Xseq6GqM4WcVg2Pwr9PS3aaH/SKDE6yVoPXRM2wXRAxIdxayqm/RQgG88jAKgg+Ub5DKW/c9NLLbUf/WdY9SgQDJtqeZCMv7G3/IzW34KZgVPsqSrPByzZXbf7KgYkYLQlscH4mcUctk1qxhdCae//zcgUZo/utpXWbPXQqtvDpuqrg9IRvoGxa/D1I7dLSJsVnk4aP7RW18vn4HJ82C2AiEp+lU2TQE9y5lXcGssZVIa5aZNTWL90HVer3Kg6AnHffvdCSZ/UHsMZJFURUXL9fRIlWVGuEDeQOqlV6lUmEtp/BiEdV4D5PuCyT6snsmEwkc51goyqh6uS6XhJyqYEQdxdoybznwp91tVmASsRybppIGHTkcWN5csF4zQt40tEwd8LoqM+bBUo0wxKiKsNsecL4JA+YDYs2saZY9U3s8jAaIon+qDu071fPRaPEvBhYHYDhy4cTvBXibyGUYGHkrgLu0w19wDfHcJKt2In58yOmaCCLNoTGp/ZLNVRyZ8VDlj/NdJ2dWpMsL2Aj7OxU065kCL2FlvuRU=
cache:
- bundler
- bundler
before_install:
- brew update
- brew upgrade carthage || true
- carthage version
- carthage bootstrap --platform $PLATFORM
- brew update
- brew upgrade carthage || true
- carthage version
- carthage bootstrap --platform $PLATFORM
script:
- bundle exec rake ci[$PLATFORM]
- bundle exec rake ci[$PLATFORM]
after_success:
- bash <(curl -s https://codecov.io/bash)
- bash <(curl -s https://codecov.io/bash)
795 changes: 752 additions & 43 deletions CHANGELOG.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1 +1 @@
github "facebook/ios-snapshot-test-case" "c1808fb4435ffc3db2203e7623935f39fc31aa8f"
github "facebook/ios-snapshot-test-case" "ed4e6a6e81bfb69a5223156e6c3d389a416cf6e3"
15 changes: 0 additions & 15 deletions Carthage.xcconfig

This file was deleted.

2 changes: 1 addition & 1 deletion Charts.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "Charts"
s.version = "3.0.2"
s.version = "3.0.4"
s.summary = "Charts is a powerful & easy to use chart library for iOS, tvOS and OSX (and Android)"
s.homepage = "https://github.com/danielgindi/Charts"
s.license = { :type => "Apache License, Version 2.0", :file => "LICENSE" }
Expand Down
1,641 changes: 848 additions & 793 deletions Charts.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

79 changes: 26 additions & 53 deletions Charts.xcodeproj/xcshareddata/xcschemes/Charts.xcscheme
Original file line number Diff line number Diff line change
@@ -1,101 +1,74 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0820"
LastUpgradeVersion = "0900"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForAnalyzing = "YES"
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
buildForArchiving = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F231D8110E600722320"
BuildableName = "Charts.framework"
BlueprintName = "Charts"
ReferencedContainer = "container:Charts.xcodeproj">
BuildableIdentifier = 'primary'
BlueprintIdentifier = 'A58A4ED274A941CA248EA921'
BlueprintName = 'Charts'
ReferencedContainer = 'container:Charts.xcodeproj'
BuildableName = 'Charts.framework'>
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
codeCoverageEnabled = "YES">
buildConfiguration = "Debug"
codeCoverageEnabled = "NO">
<AdditionalOptions>
</AdditionalOptions>
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F2D1D8110E600722320"
BuildableName = "ChartsTests.xctest"
BlueprintName = "ChartsTests"
ReferencedContainer = "container:Charts.xcodeproj">
BuildableIdentifier = 'primary'
BlueprintIdentifier = 'F2749BD5443C1CB5FE2080C2'
BlueprintName = 'ChartsTests'
ReferencedContainer = 'container:Charts.xcodeproj'
BuildableName = 'ChartsTests.xctest'>
</BuildableReference>
</TestableReference>
</Testables>
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F231D8110E600722320"
BuildableName = "Charts.framework"
BlueprintName = "Charts"
ReferencedContainer = "container:Charts.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
buildConfiguration = "Debug"
allowLocationSimulation = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F231D8110E600722320"
BuildableName = "Charts.framework"
BlueprintName = "Charts"
ReferencedContainer = "container:Charts.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
<EnvironmentVariables>
<EnvironmentVariable
key = "FB_REFERENCE_IMAGE_DIR"
value = "$(SOURCE_ROOT)/Tests/ReferenceImages"
isEnabled = "YES">
key = 'FB_REFERENCE_IMAGE_DIR'
value = '$(SOURCE_ROOT)/Tests/ReferenceImages'
isEnabled = 'YES'>
</EnvironmentVariable>
</EnvironmentVariables>
<AdditionalOptions>
</AdditionalOptions>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F231D8110E600722320"
BuildableName = "Charts.framework"
BlueprintName = "Charts"
ReferencedContainer = "container:Charts.xcodeproj">
</BuildableReference>
</MacroExpansion>
debugDocumentVersioning = "YES"
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES">
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
Expand Down
70 changes: 26 additions & 44 deletions Charts.xcodeproj/xcshareddata/xcschemes/ChartsTests.xcscheme
Original file line number Diff line number Diff line change
@@ -1,92 +1,74 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0820"
LastUpgradeVersion = "0900"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForAnalyzing = "YES"
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "NO">
buildForProfiling = "YES"
buildForArchiving = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F2D1D8110E600722320"
BuildableName = "ChartsTests.xctest"
BlueprintName = "ChartsTests"
ReferencedContainer = "container:Charts.xcodeproj">
BuildableIdentifier = 'primary'
BlueprintIdentifier = 'F2749BD5443C1CB5FE2080C2'
BlueprintName = 'ChartsTests'
ReferencedContainer = 'container:Charts.xcodeproj'
BuildableName = 'ChartsTests.xctest'>
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
buildConfiguration = "Debug"
codeCoverageEnabled = "YES">
<AdditionalOptions>
</AdditionalOptions>
<Testables>
<TestableReference
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F2D1D8110E600722320"
BuildableName = "ChartsTests.xctest"
BlueprintName = "ChartsTests"
ReferencedContainer = "container:Charts.xcodeproj">
BuildableIdentifier = 'primary'
BlueprintIdentifier = 'F2749BD5443C1CB5FE2080C2'
BlueprintName = 'ChartsTests'
ReferencedContainer = 'container:Charts.xcodeproj'
BuildableName = 'ChartsTests.xctest'>
</BuildableReference>
</TestableReference>
</Testables>
<AdditionalOptions>
</AdditionalOptions>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
buildConfiguration = "Debug"
allowLocationSimulation = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F2D1D8110E600722320"
BuildableName = "ChartsTests.xctest"
BlueprintName = "ChartsTests"
ReferencedContainer = "container:Charts.xcodeproj">
</BuildableReference>
</MacroExpansion>
<AdditionalOptions>
</AdditionalOptions>
<EnvironmentVariables>
<EnvironmentVariable
key = "FB_REFERENCE_IMAGE_DIR"
value = "$(SOURCE_ROOT)/Tests/ReferenceImages"
isEnabled = "YES">
key = 'FB_REFERENCE_IMAGE_DIR'
value = '$(SOURCE_ROOT)/Tests/ReferenceImages'
isEnabled = 'YES'>
</EnvironmentVariable>
</EnvironmentVariables>
<AdditionalOptions>
</AdditionalOptions>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "06165F2D1D8110E600722320"
BuildableName = "ChartsTests.xctest"
BlueprintName = "ChartsTests"
ReferencedContainer = "container:Charts.xcodeproj">
</BuildableReference>
</MacroExpansion>
debugDocumentVersioning = "YES"
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES">
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
Expand Down
Loading