-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the dropdown when the user clicks outside of it #99179
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~166 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~166 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described! Thanks!
Any reason these dropdowns were implemented with low-level components, rather than something like CustomSelectControl? There are a lot of implementational details involved in a custom dropdown like this, including click away behavior as implemented here, but also Escape key handling, Tab key handling, typeahead, etc. that are still missing. It's a lot of extra work to do these correctly from scratch/low-level. |
Related to #99090
There is an alternative of using useClickAway, but it is a new dependency.
Proposed Changes
Why are these changes being made?
Testing Instructions
/start
, choose a paid product to appear on the Checkout step.Pre-merge Checklist