Move collision merge attack #33
Conversation
There was a problem hiding this comment.
Added code looks clean and code follows Clean Architecture and SOLID principles. Great job with your documentation in Attack.java. It made it significantly easier to understand the functionality of each function. Small note, I think there is some commented out code in the MeleeEnemy.java file that should be removed. Overall great job!
| private void enemyMovement() { //In order to update current enemy location must update absXenemy. | ||
| distance = Math.sqrt((Math.pow((gamePanel.player.getAbsXPlayer() - xEnemy - spawnX + 1896),2) + Math.pow((gamePanel.player.getAbsYPlayer() - yEnemy -spawnY + 1046), 2))); | ||
| if (distance < 600 & distance > 110) { |
There was a problem hiding this comment.
This is the code block that I was referring to in my previous comment. This chunk of commented out code should be removed.
| //TODO: Abu | ||
| // - Remove Player from gamePanel | ||
| // - Implement CLEAN way of changing velocity following SOLID PRINCIPLES |
There was a problem hiding this comment.
I think these TODOs are very helpful in making sure everyone know what they need to focus on. I think we should make this a standard if possible.
There was a problem hiding this comment.
Super cool! The animations are amazing. I admire the separation of policies from the details of your code implementation. You could improve that further in future by increasing more cohesion with the commonalities between the different types of enemies. Great job, overall!
qwet1235
dismissed stale reviews from jaffarkeikei, khushil-sketch, and kevinzshen
via
13991c2
|
SORRYYY PLEASE ADD MORE REVIEWS CAUSE I ACCIDENTALLY COMMITTED STUFF I SHOULDNT HAVEEE!!!! ITS STILL THE SAME AS BEFORE THE LAST COMMIT. YALLS CAN JUST LEAVE THE SAME REVIEW COMMENT FROM THE LAST ONE |
There was a problem hiding this comment.
Super cool! The animations are amazing. I admire the separation of policies from the details of your code implementation. You could improve that further in future by increasing more cohesion with the commonalities between the different types of enemies. Great job, overall!
qwet1235
dismissed stale reviews from jaffarkeikei and khushil-sketch
via
07874a1
|
This is not done. There are still some methods that need to be updated after the other use cases get implemented. |
No description provided.