Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bounding box tests #41

Closed
wants to merge 1 commit into from

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Feb 17, 2022

Some test cases for proper handling of bounding boxes from glTF assets, taking into account the y-up-to-z-up transform, and including some code snippets for computing the proper boundingVolume.box from the bounds of a glTF asset.

Preview: https://github.com/javagl/3d-tiles-samples/tree/add-bounding-box-tests/next/BoundingBoxTests

@lilleyse
Copy link
Contributor

Nice! This will save hours of frustration... I hope 😄

@javagl
Copy link
Contributor Author

javagl commented Mar 24, 2022

This PR is obsolete: #45 contains the addition of the model itself, and the feedback from this PR.

@javagl javagl closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants