Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples for 3D Tiles 1.1 #45

Merged
merged 12 commits into from
Mar 24, 2022
Merged

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Mar 24, 2022

This PR aims at bringing the samples into an updated and consistent state for the transition from "3D Tiles Next" to "3D Tiles 1.1".

It summarizes the following PRs:

It addresses some points from CesiumGS/3d-tiles#562 (comment) :

  • Removed the next folder (everything goes into 1.1 now)
  • Removed the TilesetWithExpiration sample (this was never part of the specification)
  • Updated the Sandcastle sample code for the existing/added 1.1 samples

Also fixes #44 via javagl@f3c25d8

@javagl
Copy link
Contributor Author

javagl commented Mar 24, 2022

Fixes #39

@javagl javagl linked an issue Mar 24, 2022 that may be closed by this pull request
@lilleyse
Copy link
Contributor

Looks good!

@lilleyse lilleyse merged commit ec9742f into CesiumGS:main Mar 24, 2022
@lilleyse
Copy link
Contributor

Will MultipleContents be added back once it's reprocessed as 1.1? It's still a good example even if there's some overlap with MetadataGranularities.

@javagl
Copy link
Contributor Author

javagl commented Jun 20, 2022

The MultipleContents example is now added via #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetadataGranularities validation failure The TilesetWithExpiration sample should be removed
2 participants