-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples for 3D Tiles 1.1 #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review feedback not integrated yet.
Still the state from Next. To be updated to 1.1.
This was referenced Mar 24, 2022
Closed
Fixes #39 |
Looks good! |
Will MultipleContents be added back once it's reprocessed as 1.1? It's still a good example even if there's some overlap with MetadataGranularities. |
The MultipleContents example is now added via #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at bringing the samples into an updated and consistent state for the transition from "3D Tiles Next" to "3D Tiles 1.1".
It summarizes the following PRs:
It addresses some points from CesiumGS/3d-tiles#562 (comment) :
next
folder (everything goes into1.1
now)TilesetWithExpiration
sample (this was never part of the specification)Also fixes #44 via javagl@f3c25d8