Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the API code to know when the last save was. #5203

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Add the API code to know when the last save was. #5203

merged 10 commits into from
Jan 16, 2025

Conversation

realSquidCoder
Copy link
Contributor

This code is supposed to note down what the millisecond time is on save or load and be able to return the difference from that time and now to give to notifications.lua

myk002
myk002 reviewed Jan 15, 2025
View reviewed changes
library/LuaApi.cpp Outdated Show resolved Hide resolved
library/include/modules/Persistence.h Outdated Show resolved Hide resolved
library/modules/Persistence.cpp Outdated Show resolved Hide resolved
library/modules/Persistence.cpp Outdated Show resolved Hide resolved
library/modules/Persistence.cpp Outdated Show resolved Hide resolved
library/modules/Persistence.cpp Outdated Show resolved Hide resolved
@realSquidCoder realSquidCoder requested a review from myk002 January 15, 2025 21:15
@realSquidCoder
Copy link
Contributor Author

unsure if i missed anything besides docs

@realSquidCoder realSquidCoder marked this pull request as ready for review January 15, 2025 21:23
myk002
myk002 reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs go in Lua API.rst

library/LuaApi.cpp Outdated Show resolved Hide resolved
library/LuaApi.cpp Outdated Show resolved Hide resolved
library/LuaApi.cpp Outdated Show resolved Hide resolved
library/include/modules/Persistence.h Outdated Show resolved Hide resolved
library/modules/Persistence.cpp Outdated Show resolved Hide resolved
library/modules/Persistence.cpp Outdated Show resolved Hide resolved
library/modules/Persistence.cpp Outdated Show resolved Hide resolved
myk002
myk002 reviewed Jan 15, 2025
View reviewed changes
docs/dev/Lua API.rst Outdated Show resolved Hide resolved
docs/dev/Lua API.rst Outdated Show resolved Hide resolved
library/LuaApi.cpp Outdated Show resolved Hide resolved
library/LuaApi.cpp Outdated Show resolved Hide resolved
library/LuaApi.cpp Outdated Show resolved Hide resolved
@realSquidCoder realSquidCoder mentioned this pull request Jan 15, 2025
Merged
myk002
myk002 reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good! all it needs now is changelog entries (API and Lua sections)

@myk002 myk002 merged commit b60c525 into DFHack:develop Jan 16, 2025
14 checks passed
@realSquidCoder realSquidCoder deleted the squid-saverem-api branch January 16, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myk002 myk002 myk002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
50.15-r2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realSquidCoder @myk002