Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for callback #14

Merged
merged 2 commits into from
May 14, 2024
Merged

Test for callback #14

merged 2 commits into from
May 14, 2024

Conversation

TonyCTHsu
Copy link
Contributor

No description provided.

@TonyCTHsu TonyCTHsu requested a review from lloeki as a code owner May 10, 2024 09:44
Base automatically changed from tonycthsu/docker to main May 10, 2024 14:32
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/test-callback branch from 6cd3841 to b5a14f9 Compare May 13, 2024 12:11
@@ -0,0 +1,87 @@
require "minitest/spec"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a spec it should be named callback_spec and go inside the spec directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this right now, revisit later.

@TonyCTHsu TonyCTHsu merged commit d09a863 into main May 14, 2024
13 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/test-callback branch May 14, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants