-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type check in CI, ignoring the result #5
Conversation
Ha, failing with:
|
Not sure about this, maybe it would be better committing the lock?
@@ -19,3 +19,8 @@ jobs: | |||
run: bundle exec rake standard | |||
- name: Lint with Rubocop | |||
run: bundle exec rake rubocop | |||
- name: Check types | |||
run: | | |||
bundle exec rbs collection install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should do this or commit the lock file.
Interestingly enough that's the kind of thing that's not handled by the magic ruby/setup-ruby
+bundler-cache
GHA...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like with we are committing to do perform check
with a specific ruby version, it does not harm to have the rbs collection lockfile checked into git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thought. Most things in the collection are version independent (the 0
directory) so it's not really an issue right now.
Let's keep it this way and we'll see.
@@ -19,3 +19,8 @@ jobs: | |||
run: bundle exec rake standard | |||
- name: Lint with Rubocop | |||
run: bundle exec rake rubocop | |||
- name: Check types | |||
run: | | |||
bundle exec rbs collection install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like with we are committing to do perform check
with a specific ruby version, it does not harm to have the rbs collection lockfile checked into git.
Ignoring results because typing is not yet complete: this is to set up the struts of type checking execution in CI.