Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type check in CI, ignoring the result #5

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented May 6, 2024

Ignoring results because typing is not yet complete: this is to set up the struts of type checking execution in CI.

@lloeki
Copy link
Member Author

lloeki commented May 6, 2024

Ha, failing with:

#<Errno::ENOENT: No such file or directory @ rb_sysopen - /home/runner/work/graft-rb/graft-rb/rbs_collection.lock.yaml>

@lloeki lloeki requested a review from TonyCTHsu May 6, 2024 15:10
Not sure about this, maybe it would be better committing the lock?
@@ -19,3 +19,8 @@ jobs:
run: bundle exec rake standard
- name: Lint with Rubocop
run: bundle exec rake rubocop
- name: Check types
run: |
bundle exec rbs collection install
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should do this or commit the lock file.

Interestingly enough that's the kind of thing that's not handled by the magic ruby/setup-ruby+bundler-cache GHA...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like with we are committing to do perform check with a specific ruby version, it does not harm to have the rbs collection lockfile checked into git.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thought. Most things in the collection are version independent (the 0 directory) so it's not really an issue right now.

Let's keep it this way and we'll see.

@@ -19,3 +19,8 @@ jobs:
run: bundle exec rake standard
- name: Lint with Rubocop
run: bundle exec rake rubocop
- name: Check types
run: |
bundle exec rbs collection install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like with we are committing to do perform check with a specific ruby version, it does not harm to have the rbs collection lockfile checked into git.

@lloeki lloeki merged commit 389749e into main May 7, 2024
3 checks passed
@lloeki lloeki deleted the add-type-check-in-ci branch May 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants