Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type check in CI, ignoring the result #5

Merged
merged 2 commits into from
May 7, 2024
Merged

Add type check in CI, ignoring the result #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
788b38b
Add type check in CI, ignoring the result
lloeki May 6, 2024
ee76f31
Install RBS collection
lloeki May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,8 @@ jobs:
run: bundle exec rake standard
- name: Lint with Rubocop
run: bundle exec rake rubocop
- name: Check types
run: |
bundle exec rbs collection install
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should do this or commit the lock file.

Interestingly enough that's the kind of thing that's not handled by the magic ruby/setup-ruby+bundler-cache GHA...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like with we are committing to do perform check with a specific ruby version, it does not harm to have the rbs collection lockfile checked into git.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thought. Most things in the collection are version independent (the 0 directory) so it's not really an issue right now.

Let's keep it this way and we'll see.

# TODO: swallowing result until types pass
bundle exec rake steep:check || true