Add options for madrona render #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pygpudrive/env/base_environment.py
Outdated
| @@ -44,7 +54,7 @@ def __init__( | |||
| data_dir, | |||
| device="cuda", | |||
| auto_reset=False, | |||
| render_mode="rgb_array", | |||
| render_options: dict = None, # sample {"render_mode": "madrona_rgb", "view_mode": "agent_view", "resolution": (128, 128)} | |||
There was a problem hiding this comment.
my suggestion for this is to use enums at this point instead of passing around strings. Allows for less errors than checking options as strings
pygpudrive/env/viz.py
Outdated
| @@ -254,14 +263,14 @@ def draw(self, cont_agent_mask): | |||
| radius=self.goal_radius * self.zoom_scale_x, | |||
| ) | |||
|
|
|||
| if self.render_mode == "human": | |||
| if self.render_options["pygame_option"] == "human": | |||
There was a problem hiding this comment.
in general I don't love string checking it's error prone. I know this is how it's done in gym environments by default
aaravpandya
requested review from
SamanKazemkhani,
daphne-cornelisse and
eugenevinitsky
| device="cuda", | ||
| render_mode="rgb_array", | ||
| data_dir="/home/aarav/gpudrive/build/tests/testJsons", | ||
| device="cpu", |
There was a problem hiding this comment.
do we want this change?
|
|
||
| class RenderMode(Enum): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.