Object Heights #305
Closed
Object Heights #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo:
|
daphne-cornelisse
approved these changes
Dec 4, 2024
|
Just realized that this may negatively impact RL training with the current dataset. Can we merge this after we update the dataset? |
|
Why would this negatively impact training? Is it just a slight increase in the size of the observation? |
I think the current (nocturne) dataset doesn't have a field for vehicle heights, so the indices may be different. |
aaravpandya
reviewed
Dec 5, 2024
nadarenator
force-pushed
the
feat/object_heights
branch
from
20053f2 to
2b4ffa9
Compare
|
Can you rebase this over main so I can run some tests? Thanks! |
It's on the latest main commit already so you should be able to run tests! |
|
These changes were merged to a different pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to read object heights from json and make them available via corresponding tensor exports in gpudrive.