Add plot expert trajectories #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expert_trajectories: The global state of expert from `LogTrajectory`. | ||
| """ | ||
| if self.vis_config.draw_expert_trajectories: | ||
| controlled_mask = self.controlled_agents[env_idx, :] |
There was a problem hiding this comment.
It looks like the "draw_only_ego_expert_traj" draws the trajectories for all controlled vehicles. If that is correct, I'd suggest changing the name for clarity
There was a problem hiding this comment.
Thanks for the comment! How about "draw_only_controllable_veh"? Let me know what you think :)
There was a problem hiding this comment.
Yes, I think that is more descriptive! Could you please change the name? I'll approve it so you can merge the PR after
daphne-cornelisse
approved these changes
Jan 20, 2025
|
I have updated the variable name as suggested. Thanks for your feedback! |
daphne-cornelisse
added a commit
that referenced
this pull request
Jan 26, 2025
* Add plot expert trajectories (#325) * Add: plot expert trajectories * Refactor: rename draw_only_controllable_veh variable * Export map names * Handle set maps case * Add env helper func to extract filenames from worlds --------- Co-authored-by: Kyungbeom Kim <[email protected]> Co-authored-by: Daphne Cornelisse <[email protected]>
daphne-cornelisse
added a commit
that referenced
this pull request
Jan 27, 2025
* Add plot expert trajectories (#325) * Add: plot expert trajectories * Refactor: rename draw_only_controllable_veh variable * Export map names * Handle set maps case * Add env helper func to extract filenames from worlds * Dont use sizeof() for loop indexing --------- Co-authored-by: Kyungbeom Kim <[email protected]> Co-authored-by: Daphne Cornelisse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to visualize expert trajectories.
This option can be turned on/off with two booleans:
draw_expert_trajectories: A boolean indicating whether to draw expert trajectories.
draw_only_ego_expert_traj:: A boolean indicating whether to draw only ego trajectories (only effective if
draw_expert_trajectoriesis True)Behavior
draw_expert_trajectories=False,draw_only_ego_expert_traj=True/Falsedraw_expert_trajectories=True,draw_only_ego_expert_traj=Falsedraw_expert_trajectories=True,draw_only_ego_expert_traj=True