Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Visualizer #350

Merged
merged 10 commits into from
Feb 20, 2025
Merged

3D Visualizer #350

merged 10 commits into from
Feb 20, 2025

Conversation

nadarenator
Copy link
Collaborator

@nadarenator nadarenator commented Feb 17, 2025

This PR adds:

  • 3D visualization using Matplotlib.
  • Colorbar legend for plotting rollouts.

TODO:

  • Update docstrings.
  • Fix 2d rendering.
  • Fix Z-ordering.
  • Update visualizer demo.
  • Restructure nested function calls.
  • Dark Mode.

@daphne-cornelisse
Copy link
Contributor

A couple of comments on the visualizer:

  • What is the extend_goals argument for? Can we convert this to a util function instead of having the code as part of plot_simulator_state()?
  • Could you make sure that the arguments are briefly described in the docstrings?

@nadarenator
Copy link
Collaborator Author

* What is the `extend_goals` argument for? Can we convert this to a util function instead of having the code as part of `plot_simulator_state()`?

It plots where the goals would be if they were behind the agents. Useful to screen for plausible scenes in hand-designed experiments. Its better off as part of the plot_simulator_state() function in my opinion, because it uses a lot of the local variables (such as the sim object).

* Could you make sure that the arguments are briefly described in the docstrings?

Will do!

@daphne-cornelisse
Copy link
Contributor

Looks great! Feel free to merge

@daphne-cornelisse daphne-cornelisse marked this pull request as ready for review February 20, 2025 17:21
@nadarenator nadarenator merged commit ac69b06 into dev Feb 20, 2025
1 check failed
@nadarenator nadarenator deleted the kj/viz_improv branch February 20, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants