Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PR #52

Closed
wants to merge 35 commits into from
Closed

Cleanup PR #52

wants to merge 35 commits into from

Conversation

aaravpandya
Copy link
Collaborator

This PR does the following

  1. Cover the export sizes of the observations behind static asserts so that they are always correct and cannot be incorrectly set.
  2. Introduce collision behaviour params
  3. Set up hooks for testing on every merge.

@aaravpandya
Copy link
Collaborator Author

The scope of the PR has increased due to various correlated things that were hard to separate out. In addition to the above, the following changes are also implemented.

  1. Ignore collisions for certain types of entities
  2. Refactor the Map object location from init.hpp to types.hpp to reuse EntityType enum. This way we can reduce the repetition caused by MapObjectType and MapRoadType, maintain consistency and track types globally
  3. The types are now specified in more detail to facilitate collision ignorance.
  4. The behaviour of the agents on collision can now be controlled by a new enum in the params -
    enum class CollisionBehaviour: uint32_t
    {
        AgentStop,
        AgentRemoved,
        Ignore
    };

@aaravpandya aaravpandya mentioned this pull request Mar 13, 2024
@aaravpandya aaravpandya mentioned this pull request Mar 15, 2024
@aaravpandya aaravpandya deleted the ap_cleanup branch October 4, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants