Tidying the metadata bottom right_click #9358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
@Fidel365 thanks, the new Column metadata bottom menu looks fine now. And it isa simpler than before, as well as being consistent.
@N-thony the display, from the R-viewer, still ignores the metadata, but that can come later. I would be happy for this to be merged now. We are writing the help for this, so it fits nicely.
If merged, and you are re-doing Version 0.8.1, maybe it can be included? But don't do a new version 0.8.1 just for this.
N-thony
requested changes
Jan 15, 2025
instat/ucrDataFrameMetadata.vb
Outdated
| @@ -200,7 +200,7 @@ Public Class ucrDataFrameMetadata | |||
| dlgCopyDataFrame.ShowDialog() | |||
| End Sub | |||
|
|
|||
| Private Sub viewSheet_Click(sender As Object, e As EventArgs) Handles viewSheet.Click | |||
| Private Sub viewSheet_Click(sender As Object, e As EventArgs) | |||
There was a problem hiding this comment.
Is this sub still needed?
|
@N-thony I did get rid of the sub and this is ready. |
N-thony
approved these changes
Jan 16, 2025
rdstern
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #9357 partially.
@rdstern all is well except for point 2, where I went with option b but still believe there may be a way for a instead, just need to investigate and that can come in another PR, so this is ready otherwise.