Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding open refine menu mainly #9383

Closed

Conversation

Fidel365
Copy link
Contributor

@Fidel365 Fidel365 commented Jan 22, 2025

Fixes partly issue #9374 and partly issue #9366
@rdstern I say partly for the 1st issue because I have just hidden the dialog and further discussions are to continue.
For the second issue, It fixes mainly part where we receive an error message when no dataframe is loaded-let me know if you are happy. Also, I request you merge approve PR #9358 so that I can continue working on this.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fidel365 yes but you now have 2 horizontal lines together. Please get rid of one of them.

@Fidel365
Copy link
Contributor Author

closing as we move to Pr #9390

@Fidel365 Fidel365 closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants