Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added climdex.pcic Package #9379

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

MeSophie
Copy link
Contributor

Fixes #9373
@rachelkg @N-thony @rdstern I added climdex.pic package on the list of install package dialog. Please have a look.

Comment on lines 254 to 262
Private Sub UseclimdexPackage()
If ucrInputPackage.GetText = "climdex.pcic" Then
ucrInputRepositoryName.SetText("pacificclimate")
Else
ucrInputRepositoryName.SetText("IDEMSInternational")
End If

End Sub

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie you did too much! I don't think we even need this since we have forked a copy into our repo (and they've not updated for 7+ years). You only need to do the change on line 46 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilyclements This is solved

Copy link
Contributor

@lilyclements lilyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdstern over to you

@N-thony N-thony merged commit 756e2be into IDEMSInternational:master Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Climdex.pcic
3 participants