Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added climdex.pcic Package #9379

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Added climdex.pcic Package #9379

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f5a9ff
Merge pull request #295 from IDEMSInternational/master
MeSophie Jan 10, 2025
a9f9246
Merge pull request #298 from IDEMSInternational/master
MeSophie Jan 15, 2025
f51c576
Merge pull request #300 from IDEMSInternational/master
MeSophie Jan 21, 2025
593128a
Added Climdex.Pcic package
MeSophie Jan 21, 2025
6cbd9b8
Change made
MeSophie Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions instat/dlgRPackages.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Public Class dlgInstallRPackage
dctPackages.Add("rapidpror", Chr(34) & "rapidpror" & Chr(34))
dctPackages.Add("openappr", Chr(34) & "openappr" & Chr(34))
dctPackages.Add("networkGraphsR", Chr(34) & "networkGraphsR" & Chr(34))
dctPackages.Add("climdex.pcic", Chr(34) & "climdex.pcic" & Chr(34))
ucrInputPackage.SetItems(dctPackages)

ucrPnlRPackages.AddParameterValuesCondition(rdoCRAN, "checked", "cran")
Expand Down Expand Up @@ -246,9 +247,19 @@ Public Class dlgInstallRPackage
Private Sub ucrInputRepositoryName_ControlContentsChanged(ucrChangedControl As ucrCore) Handles ucrInputRepositoryName.ControlValueChanged
TestOkEnabled()
GithubOption()
UseclimdexPackage()
bUniqueChecked = False
End Sub

Private Sub UseclimdexPackage()
If ucrInputPackage.GetText = "climdex.pcic" Then
ucrInputRepositoryName.SetText("pacificclimate")
Else
ucrInputRepositoryName.SetText("IDEMSInternational")
End If

End Sub

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie you did too much! I don't think we even need this since we have forked a copy into our repo (and they've not updated for 7+ years). You only need to do the change on line 46 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilyclements This is solved

Private Sub GithubOption()
If Not (ucrInputPackage.IsEmpty AndAlso ucrInputRepositoryName.IsEmpty) Then
clsRepositoryFunction.AddParameter("paste", Chr(34) & ucrInputRepositoryName.GetText & "/" & ucrInputPackage.GetText() & Chr(34), bIncludeArgumentName:=False)
Expand All @@ -262,4 +273,8 @@ Public Class dlgInstallRPackage
SetRCodeForControls(True)
TestOkEnabled()
End Sub

Private Sub ucrInputPackage_ControlValueChanged(ucrChangedControl As ucrCore) Handles ucrInputPackage.ControlValueChanged
UseclimdexPackage()
End Sub
End Class
Loading