Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the view menu and hiding the open refine dialog #9390

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Fidel365
Copy link
Contributor

Fixes issues partially #9374, #9368 and #9366 and replaces PR #9383 .
@rdstern this is where I got, you can review it but I will finish the small remaining items on monday, Enjoy your weekend!

@rdstern
Copy link
Collaborator

rdstern commented Jan 24, 2025

@Fidel365 that is coming on, but it also makes me nervous. So I have one more small task on #9366, in b) below. Then I suggest we merge. Then have a separate pull request on #9368.
a) The #9374 item of hiding Open Refine seems fine now.
b) The #9366 move of the Swap Data and Column Metadata, and adding Data Frame Metadata is almost ok.
For that, you can't have both items ticked. So, if (say) Swap Column Metadata is ticked and active, then if you tick Swap DataFrame Metadata, then you should automatically unick the other swap - and vv.
c) I quite strongly suggest you complete those two and then merge and attack #9368 as a separate pull request. The code for the View Windows stuff is apparently a can of worms, so lets not mix it with simpler tasks,

@Fidel365
Copy link
Contributor Author

@rdstern I'm working to resolve the issue of the toolbar column metadata not coming at first load hence getting an empty column metadata, alongside the translation of the items in a fresh PR that will mainly tackle the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants