Adding 36i #13646
Open
Adding 36i #13646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jan 1, 2025
| @@ -114,6 +114,7 @@ namespace librealsense | |||
| case ds::RS430I_PID: | |||
| case ds::RS435_RGB_PID: | |||
| case ds::RS435I_PID: | |||
| case ds::RS436I_PID: | |||
There was a problem hiding this comment.
This is a question.
Should we use color values like D435 or D455?
Nir-Az
reviewed
Jan 1, 2025
src/ds/d400/d400-factory.cpp
Outdated
| dev_info, d400_device::_hw_monitor, get_firmware_logs_command(), get_flash_logs_command()) | ||
| { | ||
| check_and_restore_rgb_stream_extrinsic(); | ||
| if (_fw_version >= firmware_version(5, 16, 0, 0)) |
There was a problem hiding this comment.
Don't think we need it the fw version check.
The FW that will support D436i is higher
Nir-Az
reviewed
Jan 1, 2025
src/ds/d400/d400-factory.cpp
Outdated
| }; | ||
| } | ||
|
|
||
| bool is_rgb_extrinsic_valid(const std::vector<uint8_t>& raw_data) const |
There was a problem hiding this comment.
Do we have this function on D455 too?
There was a problem hiding this comment.
no - it is in D435i only.
It now appears for 36i because I copied from there - I ll check it.
Nir-Az
reviewed
Jan 1, 2025
src/ds/d400/d400-private.h
Outdated
| @@ -155,6 +161,7 @@ namespace librealsense | |||
| {RS435_RGB_PID, "5.8.15.0" }, | |||
| {RS405U_PID, "5.8.15.0" }, | |||
| {RS435I_PID, "5.12.7.100" }, | |||
| {RS436I_PID, "5.16.3.100" }, | |||
There was a problem hiding this comment.
Please add a TODO update the final FW version
|
Let\s add a camera shader 3D model for D436i. librealsense/src/gl/camera-shader.cpp Line 167 in f7f622e (needs to follow the changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-3024