collect DICOM files based on magic bytes #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2020 13:48
According to the DICOM standard [1], every DICOM file should have the characters "DICM" as their magic bytes. This should be more reliable than checking the file extensions. [1] http://dicom.nema.org/medical/dicom/current/output/chtml/part10/chapter_7.html#table_7.1-1
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 88.82% 89.75% +0.93%
==========================================
Files 2 2
Lines 340 371 +31
==========================================
+ Hits 302 333 +31
Misses 38 38
Continue to review full report at Codecov.
|
|
This is indeed a much better way of identifying DICOM files. Thanks! I'll make a note here that in some applications, the DICOM file doesn't contain the magic bytes (#5) but this is uncommon and can be addressed later. |
|
Thanks for merging! Keep up the good work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the DICOM standard [1], every DICOM file should has the characters "DICM" as their magic bytes.
This should be more reliable than checking the file extensions.
[1] http://dicom.nema.org/medical/dicom/current/output/chtml/part10/chapter_7.html#table_7.1-1