Fix iOS / Android CMake builds #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boolean OFF is the default value: https://cmake.org/cmake/help/latest/command/option.html
|
Do you know why the new CIs failed? I don't want to merge if they will start to fail for everyone else. |
Could you try running the actions? Last time I checked it looked like a permissions issue the runs just never started. |
juan-lunarg
commented
Nov 27, 2023
I couldn't figure out why the new CI failed even on my fork. I've removed the new CI from this PR |
juan-lunarg
changed the title
s-perron
approved these changes
Nov 28, 2023
We have integration testing for iOS / Android in the vulkan validation layers and glslang. Which will do for now. |
arcady-lunarg
pushed a commit
to KhronosGroup/glslang
that referenced
this pull request
Nov 29, 2023
As of KhronosGroup/SPIRV-Tools/pull/5482 SPIRV-Tools builds cleanly for Android/iOS by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4437