feat(benches): add two new binaries to benchmark scaling #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to rezrite split_edge_noalloc to be a transactional routine
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 84.94% 84.98% +0.03%
==========================================
Files 62 63 +1
Lines 9407 9302 -105
==========================================
- Hits 7991 7905 -86
+ Misses 1416 1397 -19 ☔ View full report in Codecov by Sentry. |
these will be generalized to cell insertion anyway
now there are issues due to asserts in core operations; since the assertions operate in-transaction, some forward passed values can mess up the checks
cedricchevalier19
approved these changes
Feb 12, 2025
| @@ -35,6 +35,28 @@ impl<T: CoordsFloat> CMap2<T> { | |||
| self.unused_darts.iter().filter(|v| v.read_atomic()).count() | |||
| } | |||
|
|
|||
| /// Return whether a given dart is unused or not. | |||
| #[must_use = "unused return value"] | |||
| pub fn is_unused(&self, d: DartIdType) -> bool { | |||
There was a problem hiding this comment.
Is it necessary to have it in a public-facing interface?
| println!("topology checked in {}ms", instant.elapsed().as_millis()); | ||
| } | ||
|
|
||
| let backend = if std::env::var("BACKEND").is_ok_and(|s| &s == "rayon") { |
There was a problem hiding this comment.
Command line arguments should be a more robust approach.
Think of printing the selected backend to confirm how the results were obtained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope: benches
Type of change: feat
Content description:
grid-random-splitbinary. it generates a fixed size unit grid with each square cell having a diagonal split, the direction being random. the map is saved as a legacy VTK binary filecut-edgesbinary. it loads a a map from a VTK file, and divide its cells iteratively until a target edge size is reached. the input mesh is assumed to be a triangle mesh, we guarantee that each intermediate step and final result are as wellis_unusedandis_unused_transacto basic map operations