-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nemotron CC SDG Pipelines and Pre-processing/Post-Processing Stages #527
Conversation
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback around modules, mostly looks good to me.
- If the document starts and ends with a quotation mark and there are | ||
newlines in the document, the quotation marks are removed only if | ||
the first line does not end with a quotation mark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this lead in a weird result?
"""
'hello my name is bla,
what's your name?'
is your name 'xyz'
?
"""
Here the quotations are quoting 'hello my name is bla, \n what's your name?'
and xyz
But the removal logic will output quotations such that the quoted phrase is is your name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry the formatting in your example is a bit weird and I'm having trouble understanding your question. Is your example meant to be one document or multiple documents? The ending ?
would cause no modifications to be made on this document. From how I am reading it I see:
example="""""hello my name is bla,
what's your name?"
is your name "xyz"?
"""
Please let me know if I have misread this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad on the formatting, I mistakenly also added the question mark
example=""""hello my name is bla,
what's your name?"
is your name "xyz"
"""
In this example first line first char and last line last char are quotation marks, so the output will be
example="""hello my name is bla,
what's your name?"
is your name "xyz
i.e initially the quoted phrase was "hello my name is bla, \n what's your name?" and "xyz"
, but once we remove the punctuation as per the algorithm, the output will be "is your name "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha thanks for clarifying. You're correct that this probably will happen, but I don't think that format of response is common in the Nemotron-CC SDG pipelines this filter was applied in. A lot of these filters have weird data edgecases, but so long as folks selectively apply them and look at their data to see the results it should be fine.
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a minor nit around type hints
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second person + some subheader suggestions.
I think these could potentially benefit from use case examples too to help highlight their differences/when to use them.
Signed-off-by: Ryan Wolf <[email protected]>
Description
Usage
The full pipelines for all of them are too much for a PR description, but here is the full pre and postprocessing pipeline for wikipedia style rephrasing.
Checklist