Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nemotron CC SDG Pipelines and Pre-processing/Post-Processing Stages #527
Add Nemotron CC SDG Pipelines and Pre-processing/Post-Processing Stages #527
Changes from 17 commits
2daedd7
cbf0ab0
56de7c6
6729a68
fe37942
95c939b
8146cc2
53c53b3
4ddecbc
46971aa
042150f
868a2b1
b0946fa
396a7f6
a8f12dd
d1d1c0c
7022a39
c53fe7d
dcf9d90
f28141d
3e9e0a2
d9ecba4
50e53e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this lead in a weird result?
"""
'hello my name is bla,
what's your name?'
is your name
'xyz'
?"""
Here the quotations are quoting
'hello my name is bla, \n what's your name?'
andxyz
But the removal logic will output quotations such that the quoted phrase is
is your name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry the formatting in your example is a bit weird and I'm having trouble understanding your question. Is your example meant to be one document or multiple documents? The ending
?
would cause no modifications to be made on this document. From how I am reading it I see:Please let me know if I have misread this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad on the formatting, I mistakenly also added the question mark
In this example first line first char and last line last char are quotation marks, so the output will be
i.e initially the quoted phrase was
"hello my name is bla, \n what's your name?" and "xyz"
, but once we remove the punctuation as per the algorithm, the output will be"is your name "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha thanks for clarifying. You're correct that this probably will happen, but I don't think that format of response is common in the Nemotron-CC SDG pipelines this filter was applied in. A lot of these filters have weird data edgecases, but so long as folks selectively apply them and look at their data to see the results it should be fine.