Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] pingvin-share: 1.1.3 -> 1.8.0 #374145

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jan 15, 2025

Manual backport of

#354105
#356551
#361751
#366607
#368297
#368297

Fixes GHSA-rjwx-p44f-mcrv

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

RatCornu and others added 7 commits January 15, 2025 16:30
(cherry picked from commit 8ec0981)
(cherry picked from commit 7872a84)
(cherry picked from commit 2738376)
(cherry picked from commit dfc3032)
(cherry picked from commit 0c278e2)
(cherry picked from commit aee5617)
(cherry picked from commit f3fe7bb)
@getchoo getchoo added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 15, 2025
@getchoo getchoo mentioned this pull request Jan 15, 2025
13 tasks
@nix-owners nix-owners bot requested a review from RatCornu January 15, 2025 21:42
@weriomat
Copy link
Contributor

Please note that strictly speaking the CVE was fixed in Version 1.4.0.

@getchoo getchoo changed the title pingvin-share: 1.1.3 -> 1.8.0 [Backport release-24.11] pingvin-share: 1.1.3 -> 1.8.0 Jan 15, 2025
@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 15, 2025
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374145


aarch64-darwin

✅ 2 packages built:
  • pingvin-share.backend
  • pingvin-share.frontend

x86_64-darwin

✅ 2 packages built:
  • pingvin-share.backend
  • pingvin-share.frontend

x86_64-linux

✅ 2 packages built:
  • pingvin-share.backend
  • pingvin-share.frontend

@wolfgangwalther wolfgangwalther merged commit 1793f6c into NixOS:release-24.11 Jan 16, 2025
36 of 39 checks passed
@getchoo getchoo deleted the backport-24.11/pingvin-share/1.8.0 branch January 16, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants