Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

48 situation module #57

Merged
merged 46 commits into from
Jan 23, 2025
Merged

48 situation module #57

merged 46 commits into from
Jan 23, 2025

Conversation

RalphBln
Copy link
Contributor

This PR adds a new situation module as a continuation of the GFO modularization effort as well as a collection of situation-related ontology patterns.

@RalphBln RalphBln linked an issue Jan 20, 2025 that may be closed by this pull request
# Conflicts:
#	modules/gfo-base.owl
@RalphBln RalphBln requested a review from AlexU75 January 20, 2025 12:02
@RalphBln RalphBln self-assigned this Jan 20, 2025
modules/gfo-base.owl Outdated Show resolved Hide resolved
@ChristophB
Copy link
Member

ChristophB commented Jan 20, 2025

At least all classes and properties must have a label.

> robot report --profile qc_report/profile.txt --input modules/gfo-connector-presentic-timeExtended.ttl

Violations: 18
-----------------
ERROR:      8
WARN:       10
INFO:       0

First 18 violations:
ERROR	missing_label	https://w3id.org/gfo/presentic/Event	rdfs:label	
ERROR	missing_label	https://w3id.org/gfo/presentic/PresenticAttributive	rdfs:label	
ERROR	missing_label	https://w3id.org/gfo/presentic/PresenticIndividual	rdfs:label	
ERROR	missing_label	https://w3id.org/gfo/presentic/PresenticObject	rdfs:label	
ERROR	missing_label	https://w3id.org/gfo/presentic/PresenticQuality	rdfs:label	
ERROR	missing_label	https://w3id.org/gfo/presentic/PresenticRelator	rdfs:label	
ERROR	missing_label	https://w3id.org/gfo/presentic/PresenticRole	rdfs:label	
ERROR	missing_label	https://w3id.org/gfo/presentic/PresenticSituation	rdfs:label	
WARN	missing_definition	https://w3id.org/gfo/connector/presentic/time-extended/hasSnapshot	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/connector/presentic/time-extended/snapshotOf	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/presentic/Event	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/presentic/PresenticAttributive	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/presentic/PresenticIndividual	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/presentic/PresenticObject	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/presentic/PresenticQuality	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/presentic/PresenticRelator	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/presentic/PresenticRole	skos:definition	
WARN	missing_definition	https://w3id.org/gfo/presentic/PresenticSituation	skos:definition	
2025-01-20 13:40:41,627 ERROR org.obolibrary.robot.ReportCommand - Report failed!

@ChristophB
Copy link
Member

The tests are failing for modules/gfo-connector-presentic-timeExtended.ttl because the result of the following SPARQL is not empty:
https://robot.obolibrary.org/report_queries/missing_label

@ChristophB
Copy link
Member

I suggest to remove examples from the reports of the test workflow.

@RalphBln RalphBln requested review from ChristophB and k00ni January 21, 2025 12:12
Copy link
Member

@ChristophB ChristophB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but I can't judge the ontological stuff. Please wait for @AlexU75's review

Copy link
Contributor

@AlexU75 AlexU75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving the GFO modules gfo-connector-presentic-timeExtended.ttl, gfo-core.ttl, gfo-presentic.ttl and gfo-timeExtended.ttl from this pull request to a separate branch.

@RalphBln RalphBln requested a review from AlexU75 January 22, 2025 23:27
@RalphBln RalphBln merged commit 1b1c0ce into main Jan 23, 2025
1 check passed
@ChristophB ChristophB deleted the 48-situation-module branch January 24, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Situation module
4 participants