Support 1.21.3. #3489

rom1504 · 2024-10-27T20:34:06Z

No description provided.

socket-security · 2024-11-25T15:53:59Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	Transitive: environment, filesystem	`+25`	3.87 MB	extremeheat
npm/[email protected]	filesystem Transitive: environment, eval, shell, unsafe	`+261`	26.4 MB	zeke
npm/[email protected]	Transitive: environment, filesystem, shell, unsafe	`+188`	18.4 MB	voxpelli
npm/[email protected]	None	`0`	22.7 MB	typescript-bot

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

boly38 · 2024-12-04T20:22:45Z

@rom1504 thanks for you huge work around this amazing project 🙏

is it possible in some way to maintain/provide in home page (ex. root readme) the latest version tested & supported
and this to avoid question/discussion about current supported version &/or error message (like No data available for version 1.21.3 & #3513) ?

I know that there is already 1.21 but it would be great to know current major.minor.patch to install without having to check patch one by one 🙏

rom1504 · 2024-12-04T20:28:18Z

@boly38 see https://github.com/PrismarineJS/mineflayer/blob/master/lib/version.js#L1

* Fix gamemode test and implementation * Add gamemode test related comments * Fix gamemode tests Add test function to kill the bot * Add gamemode out of bounds checks * Simplify gameMode parsing and check against spawnRespawnWorldDataField feature

rom1504 · 2024-12-23T22:47:30Z

current error is

TypeError: SizeOf error for undefined : Cannot read properties of undefined (reading '_value')
at Object.MovementFlags (eval at compile (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:262:12), :2320:31)
at Object.packet_position_look (eval at compile (/home/runner/work/mineflayer/mineflayer/node_modules/protodef/src/compiler.js:262:12), :2351:34)

just need to change how this is sent

extremeheat · 2025-01-07T03:56:30Z

We could do a basic PR to mineflayer so basic things work like chat without blocking on PrismarineJS/minecraft-data#948.

The things that are currently broken (like Slots in #3526) would remain broken as they are pending that PR. But we don't have to block on basically a refactor

extremeheat · 2025-01-07T12:09:08Z

Pretty much everything is working now minus setCreativeSlot. No idea why this is failing, there is nothing I see unusual in code diffs. I checked out vanilla clients with flying squid and didn't see anything abnormal there either (worked fine). It's possibly something is wrong with bot environment.

Otherwise if people want try 1.21.3 support can do

npm install prismarinejs/mineflayer#1.21.3

I'm not going to have much more time to work on this but I'll try to look into this some more when if I get the time.

rom1504 · 2025-01-07T22:10:31Z

lib/plugins/creative.js

    assert(slot >= 0 && slot <= 44)

    if (Item.equal(bot.inventory.slots[slot], item, true)) return
+
+    if (bot.registry.version['>=']('1.21.3')) {


should be a feature

lib/plugins/creative.js

rom1504 · 2025-01-07T23:08:17Z

Looks like still need an update on https://github.com/PrismarineJS/mineflayer/blob/master/test/internalTest.js#L560 and then it's done

extremeheat · 2025-01-07T23:13:17Z

Yeah, I looked into the internal failing test and it seems to be because it's expecting a display name, so it sends a display name update but then immediately erases the display name in another player_info packet. Not sure why old versions are passing. But I think we can disable the display name check for now. Or make a new test just this that doesn't have this problem.

Either way the player_info packet is going to be refactor with PrismarineJS/minecraft-data#948 to be same across versions so it will be revisited

extremeheat · 2025-01-07T23:26:07Z

This is the problem:

2025-01-07T23:22:51.9383127Z {
2025-01-07T23:22:51.9383380Z   action: {
2025-01-07T23:22:51.9383574Z     _value: 53,
2025-01-07T23:22:51.9383789Z     add_player: true,
2025-01-07T23:22:51.9384025Z     initialize_chat: false,
2025-01-07T23:22:51.9384280Z     update_game_mode: true,
2025-01-07T23:22:51.9384534Z     update_listed: false,
2025-01-07T23:22:51.9384785Z     update_latency: true,
2025-01-07T23:22:51.9385051Z     update_display_name: true,
2025-01-07T23:22:51.9385314Z     update_priority: false
2025-01-07T23:22:51.9385544Z   },
2025-01-07T23:22:51.9385714Z   data: [
2025-01-07T23:22:51.9385907Z     {
2025-01-07T23:22:51.9386293Z       uuid: '00000000-0000-0000-0000-000000000000',
2025-01-07T23:22:51.9386876Z       player: { name: 'bot5', properties: [] },
2025-01-07T23:22:51.9387295Z       chatSession: undefined,
2025-01-07T23:22:51.9387625Z       gamemode: 0,
2025-01-07T23:22:51.9387839Z       listed: undefined,
2025-01-07T23:22:51.9388070Z       latency: 0,
2025-01-07T23:22:51.9388282Z       displayName: {
2025-01-07T23:22:51.9388504Z         type: 'compound',
2025-01-07T23:22:51.9388837Z         value: { text: { type: 'string', value: 'wvffle' } }
2025-01-07T23:22:51.9389156Z       },
2025-01-07T23:22:51.9389352Z       listPriority: undefined
2025-01-07T23:22:51.9389602Z     }
2025-01-07T23:22:51.9389777Z   ]
2025-01-07T23:22:51.9390067Z }
2025-01-07T23:22:51.9390259Z {
2025-01-07T23:22:51.9390436Z   action: {
2025-01-07T23:22:51.9390625Z     _value: 53,
2025-01-07T23:22:51.9390837Z     add_player: true,
2025-01-07T23:22:51.9391073Z     initialize_chat: false,
2025-01-07T23:22:51.9391320Z     update_game_mode: true,
2025-01-07T23:22:51.9391569Z     update_listed: false,
2025-01-07T23:22:51.9391802Z     update_latency: true,
2025-01-07T23:22:51.9392021Z     update_display_name: true,
2025-01-07T23:22:51.9392242Z     update_priority: false
2025-01-07T23:22:51.9392436Z   },
2025-01-07T23:22:51.9392579Z   data: [
2025-01-07T23:22:51.9392729Z     {
2025-01-07T23:22:51.9392933Z       uuid: '00000000-0000-0000-0000-000000000000',
2025-01-07T23:22:51.9393226Z       player: { name: 'bot5', properties: [] },
2025-01-07T23:22:51.9393487Z       chatSession: undefined,
2025-01-07T23:22:51.9393696Z       gamemode: 0,
2025-01-07T23:22:51.9393878Z       listed: undefined,
2025-01-07T23:22:51.9394070Z       latency: 0,
2025-01-07T23:22:51.9394253Z       displayName: undefined,
2025-01-07T23:22:51.9394472Z       listPriority: undefined
2025-01-07T23:22:51.9394675Z     }
2025-01-07T23:22:51.9394822Z   ]
2025-01-07T23:22:51.9394965Z }

update_display_name: true is set to true twice because value 53 is being written in the internal tests displayName, once setting the displayName and then once removing it

rom1504 · 2025-01-07T23:47:47Z

lib/plugins/entities.js

@@ -583,8 +598,65 @@ function inject (bot) {
  })

  bot._client.on('player_info', (packet) => {
+    console.dir(packet, { depth: null })


rom1504 · 2025-01-07T23:50:46Z

lib/plugins/physics.js

    yaw: 0,
    pitch: 0,
    onGround: false,
-    time: 0
+    time: 0,
+    flags: bot.registry.version['>=']('1.21.3') ? {} : 0


Should probably be a feature

I reverted this, I messed up the client and serverbound position packets (serverbound doesn't have dx/dy/dz and changed onGround bool to a packed flag int so we dont need a version check)

rom1504 · 2025-01-07T23:50:57Z

lib/plugins/physics.js

+
+    let newYaw, newPitch
+
+    if (bot.registry.version['>=']('1.21.3')) {


Should be a feature

The below features can be removed after PrismarineJS/minecraft-data#948 so if there is a feature added here it would just be temporary

rom1504 · 2025-01-07T23:51:34Z

Left a few minor comments but otherwise LGTM

rom1504 · 2025-01-07T23:51:45Z

I hope 1.21.4 is more minor than this

rom1504 · 2025-01-08T08:52:32Z

/makerelease

extremeheat · 2025-01-08T10:31:35Z

Mojang said earlier they plan to do breaking changes in minor versions now so I think they will probably not worry much about big changes anymore. Probably won't get much better until LLMs can take the (java diff, current protocol spec) and apply the updates directly to the protocol spec and lib code. I looked at 1.21.4 earlier and there are some big changes to the internals for refactoring but network changes are not that bad. But there might still be behavior updates (like the one related to creative set slot) that could be annoying.

But I think since this is the new normal i think it's probably a good time to simplify as much as possible/add abstractions where needed so the code doesn't get too messy with lots of version/feature based branching

rom1504 mentioned this pull request Oct 27, 2024

Java 1.21.3 Support PrismarineJS/minecraft-data#936

Merged

7 tasks

rom1504 added 2 commits November 16, 2024 02:33

Support 1.21.3.

924f079

Update version.js

c966b63

extremeheat force-pushed the 1.21.3 branch from 50e9bc4 to c966b63 Compare November 16, 2024 07:33

Update entities.js

115939f

extremeheat mentioned this pull request Nov 25, 2024

My bot dont wants to activate "bot.setControlState" or another control #3504

Open

1 task

Merge branch 'master' into 1.21.3

1a5d5a7

boly38 mentioned this pull request Dec 4, 2024

Show compatible minecraft versions chickarmy/chickenbot-web#51

Closed

rom1504 added 2 commits December 4, 2024 21:25

Update package.json

b529c58

Update ci.yml

65be492

wubushanyan mentioned this pull request Dec 10, 2024

Got kick by server in 1.21.3 #3522

Closed

3 tasks

rom1504 mentioned this pull request Dec 27, 2024

1.21.4 #3533

Closed

rom1504 mentioned this pull request Jan 6, 2025

1.17-1.21 Support PrismarineJS/flying-squid#545

Closed

extremeheat added 6 commits January 7, 2025 08:44

21.3 work

229ee1c

fix

1184242

reduce debug logging

63654c5

outbound logging

3158bd1

fix logging

e5292d1

disable logging and --bail

a93bb2c

extremeheat added 3 commits January 7, 2025 07:11

Update internalTest.js typo

f16f406

Fix 1.21.3 set creative slot

9574cb3

revert some setInventorySlot checks

7763ccd

rom1504 commented Jan 7, 2025

View reviewed changes

fix internalTest and check

be14be2

rom1504 commented Jan 7, 2025

View reviewed changes

lib/plugins/creative.js Show resolved Hide resolved

use features

437c821

rom1504 commented Jan 7, 2025

View reviewed changes

extremeheat added 2 commits January 7, 2025 19:03

Update physics.js fix lastSent

db846cb

Remove debug logging

7acca9e

rom1504 merged commit 58ae9e5 into master Jan 8, 2025
25 checks passed

rom1504bot mentioned this pull request Jan 8, 2025

Release 4.24.0 #3545

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support 1.21.3. #3489

Support 1.21.3. #3489

rom1504 commented Oct 27, 2024

socket-security bot commented Nov 25, 2024 •

edited

Loading

boly38 commented Dec 4, 2024 •

edited

Loading

rom1504 commented Dec 4, 2024

rom1504 commented Dec 23, 2024

extremeheat commented Jan 7, 2025

extremeheat commented Jan 7, 2025

rom1504 Jan 7, 2025

rom1504 commented Jan 7, 2025

extremeheat commented Jan 7, 2025

extremeheat commented Jan 7, 2025 •

edited

Loading

rom1504 Jan 7, 2025

rom1504 Jan 7, 2025

extremeheat Jan 8, 2025

rom1504 Jan 7, 2025

extremeheat Jan 7, 2025

rom1504 commented Jan 7, 2025

rom1504 commented Jan 7, 2025

rom1504 commented Jan 8, 2025

extremeheat commented Jan 8, 2025


		let newYaw, newPitch

		if (bot.registry.version['>=']('1.21.3')) {

Support 1.21.3. #3489

Support 1.21.3. #3489

Conversation

rom1504 commented Oct 27, 2024

socket-security bot commented Nov 25, 2024 • edited Loading

boly38 commented Dec 4, 2024 • edited Loading

rom1504 commented Dec 4, 2024

rom1504 commented Dec 23, 2024

extremeheat commented Jan 7, 2025

extremeheat commented Jan 7, 2025

rom1504 Jan 7, 2025

Choose a reason for hiding this comment

rom1504 commented Jan 7, 2025

extremeheat commented Jan 7, 2025

extremeheat commented Jan 7, 2025 • edited Loading

rom1504 Jan 7, 2025

Choose a reason for hiding this comment

rom1504 Jan 7, 2025

Choose a reason for hiding this comment

extremeheat Jan 8, 2025

Choose a reason for hiding this comment

rom1504 Jan 7, 2025

Choose a reason for hiding this comment

extremeheat Jan 7, 2025

Choose a reason for hiding this comment

rom1504 commented Jan 7, 2025

rom1504 commented Jan 7, 2025

rom1504 commented Jan 8, 2025

extremeheat commented Jan 8, 2025

socket-security bot commented Nov 25, 2024 •

edited

Loading

boly38 commented Dec 4, 2024 •

edited

Loading

extremeheat commented Jan 7, 2025 •

edited

Loading