Attempt to Add ROCm Support to Qiskit Aer for AMD GPUs (issue #2113) #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyedMustafaAhmad
commented
Feb 4, 2025
There was a problem hiding this comment.
Accidentally added this commit from a different issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I made changes to build.yml, deploy.yml and added tests for the ROCm backend.
The changes include:
This is a work-in-progress (WIP), my first time attempting to write workflows and I would highly appreciate any feedback and performance optimizations for ROCm.
Details and comments
Modified Files:
Changes:
Adds a new job (wheel-gpu-rocm) that builds Qiskit Aer using AER_THRUST_BACKEND=ROCM.
Ensures that ROCm-enabled wheels are packaged and uploaded alongside CUDA and CPU builds.
Runs automated CI/CD testing for ROCm compatibility.
Looking for feedback on:
Whether the CI/CD workflow properly integrates with ROCm and any optimizations that can improve the build process. Additionally, I do not have an AMD card so I would appreciate if people could test this out on actual hardware.