Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to Add ROCm Support to Qiskit Aer for AMD GPUs (issue #2113) #2310

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Attempt to Add ROCm Support to Qiskit Aer for AMD GPUs (issue #2113) #2310

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77f6f38
Added a check to _combinecircs in estimator.py to prevent clash of re…
SyedMustafaAhmad Feb 4, 2025
8b2f725
Add ROCm support for Qiskit Aer GPU builds in deploy workflow
SyedMustafaAhmad Feb 4, 2025
5290970
Add ROCm support for Qiskit Aer GPU builds in CI pipeline
SyedMustafaAhmad Feb 4, 2025
9568173
Add ROCm unit tests to CI pipeline for Qiskit Aer GPU builds
SyedMustafaAhmad Feb 4, 2025
e37c4ba
Added tests for ROCM backend
SyedMustafaAhmad Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion qiskit_aer/primitives/estimator.py
View file
Open in desktop
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally added this commit from a different issue

Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,11 @@ def _combine_circs(circuit: QuantumCircuit, meas_circuits: list[QuantumCircuit])
circs = []
for meas_circuit in meas_circuits:
new_circ = circuit.copy()
# Track existing classical register names in new_circ
existing_creg_names = {creg.name for creg in new_circ.cregs}
for creg in meas_circuit.cregs:
new_circ.add_register(creg)
if creg.name not in existing_creg_names: # Prevent duplicate registers
new_circ.add_register(creg)
new_circ.compose(meas_circuit, inplace=True)
_update_metadata(new_circ, meas_circuit.metadata)
circs.append(new_circ)
Expand Down