-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example program #215
Merged
Merged
Add example program #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisThrasher
force-pushed
the
examples
branch
4 times, most recently
from
December 20, 2023 04:58
e193712
to
28b69bc
Compare
kimci86
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also cleanup resources when loading fails?
eXpl0it3r
reviewed
Dec 20, 2023
Do you want to enable it in CI or are you gonna do that with the other PR? |
ChrisThrasher
force-pushed
the
examples
branch
3 times, most recently
from
December 20, 2023 17:59
bcd9469
to
24dac0e
Compare
My bad that's fixed now |
This is required when compiling these headers as C code. These were omitted becuase before the addition of examples these headers were only compiled locally as C++ files where adding the void keyword is not needed.
ChrisThrasher
force-pushed
the
examples
branch
from
December 20, 2023 18:10
24dac0e
to
d00c0ba
Compare
kimci86
reviewed
Dec 20, 2023
ChrisThrasher
force-pushed
the
examples
branch
from
December 20, 2023 18:42
d00c0ba
to
4b6771e
Compare
kimci86
approved these changes
Dec 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211
I had to fix some function prototypes that were using
()
instead of(void)
to list their parameters. The latter is required when compiling these headers as C code instead of C++ code. This example program is the first time internally to CSFML that CSFML headers were compiled as C code instead of C++, thus uncovering this problem.