-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] retry if no node does support the Capabilities #14986
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@VietND96 is this a common case when using Kubernetes, when only one node is used? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nodes are not restarted after shutdown. Plus, the rejectUnsupportedCaps
configurable value keeps the request in the queue for the configured time. I think this scenario is already covered.
Some more words to the scenario, the node process is external monitored and restarted after shutdown, e.g. via container heath check. The I have stress test for the scenario, but it is currently failing due to this issue and #14987. It might be best to add this test to the PR as soon as #14987 is merged, to reproduce it and than look at it. |
222b682
to
9be0897
Compare
@diemol i have created the test As soon as the PS: the |
CI Failure Feedback 🧐(Checks updated until commit 6c43f65)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
I can confirm
|
For example, a node |
The session request should be rejected after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge after CI is green.
User description
Description
This PR will allow to retry if currently no node does support the Capabilities, this can change over time when a new node registers.
Motivation and Context
When using
--drain-after-session-count
and a single node which is automatically restarted after shutdown, this PR will allow the pending session request to retry until the node is restarted and healthy again.Types of changes
Checklist
PR Type
Bug fix
Description
--drain-after-session-count
feature with node restartsChanges walkthrough 📝
LocalDistributor.java
Add retry mechanism for unsupported capabilities
java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java