Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] retry if no node does support the Capabilities #14986

Merged
merged 7 commits into from
Jan 1, 2025
Merged

[grid] retry if no node does support the Capabilities #14986

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1ad9e3b
[grid] retry if no node does support the Capabilities
joerg1985 Dec 30, 2024
9be0897
[grid] add some unit tests to provoke the failure
joerg1985 Dec 30, 2024
ad7aad8
Merge branch 'trunk' into retry-after-drain
VietND96 Dec 31, 2024
f3d4dbb
[grid] increase the timeout of the tests
joerg1985 Jan 1, 2025
6c43f65
[grid] increase the timeouts of the tests
joerg1985 Jan 1, 2025
c67e940
[grid] disable one of the tests for now
joerg1985 Jan 1, 2025
00aa730
Merge branch 'trunk' into retry-after-drain
joerg1985 Jan 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,11 @@ public Either<SessionNotCreatedException, CreateSessionResponse> newSession(
new SessionNotCreatedException("Unable to create new session");
for (Capabilities caps : request.getDesiredCapabilities()) {
if (isNotSupported(caps)) {
// e.g. the last node drained, we have to wait for a new to register
lastFailure =
new SessionNotCreatedException(
"Unable to find a node supporting the desired capabilities");
retry = true;
continue;
}

Expand Down
Loading