TSify ExplorerWindow/Tabs #7415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
commented
Dec 24, 2024
| @@ -198,19 +217,21 @@ class AddData extends React.Component { | |||
| renderPanels() { | |||
| const { t } = this.props; | |||
| const dropdownTheme = { | |||
| // @ts-expect-error FIXME: no Styles.dropdown defined. | |||
There was a problem hiding this comment.
Need help with these, not sure why there isn't a Style.dropdown and Style.dropdownListIsOpen defined.
pjonsson
commented
Dec 24, 2024
| @@ -68,16 +76,17 @@ class MyDataTab extends React.Component { | |||
| onClick={() => this.changeTab(tab.id)} | |||
| title={tab.caption} | |||
| className={classNames(Styles.tabListBtn, { | |||
| // @ts-expect-error FIXME: No isActive defined in CssExports. | |||
There was a problem hiding this comment.
Same with this, but for Style.isActive.
pjonsson
force-pushed
the
tsify-lib-reactviews-explorerwindow-tabs-mydatatab
branch
from
74a336d to
2e62aca
Compare
pjonsson
changed the title
pjonsson
commented
Dec 25, 2024
| searchState.catalogSearchProvider | ||
| ? searchState.catalogSearchProvider | ||
| .debounceDurationOnceLoaded | ||
| terria.catalogReferencesLoaded |
There was a problem hiding this comment.
There is already a check of state.catalogSearchProvider on line 61, so removed the check on this line.
Also had to shorten searchState to get pretty to keep the @ts-expect-error in the right place.
4 tasks
pjonsson
force-pushed
the
tsify-lib-reactviews-explorerwindow-tabs-mydatatab
branch
from
2e62aca to
3b8ef53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Test me
I believe this is tested by CI?
Checklist
doc/.