Fixes #5557 - Rename standing agreement files to use full sector name #5558
Conversation
@aidenbok203 yeah please do, "Stafa" and "Trent" are the names of the two sectors that make up our PC Southeast (MAN_SE_CTR) |
|
ha, will do, not quite sure what I was thinking when I did that |
Agreements/Airport/BB_TCCOW.txt
Outdated
There was a problem hiding this comment.
Should this be COWLY?
There was a problem hiding this comment.
TCCOW is good, as this matches TCWEL/TCRED/etc.
There was a problem hiding this comment.
But isn't the point of this PR to make thing consistent, I don't see why we wouldn't do this fully consistently?
There was a problem hiding this comment.
TC COWLY is a TC, while Stafa and Trent aren’t part of TC?
There was a problem hiding this comment.
COWLY is TC, but STAFA and TNT are PC sectors; for consistency, wouldn't either TCCOW/PCSTA or COWLY/STAFA instead of a mixture of both be preferable?
There was a problem hiding this comment.
wouldn't either TCCOW/PCSTA or COWLY/STAFA
Yeah, that was my thought. I though we were renaming to full sector names, hence COWLY.
There was a problem hiding this comment.
Or could even be TCCOWLY PCSTAFA to be completely obvious.
There was a problem hiding this comment.
I don't really want to follow that logic to PCHumber or PCAntrim though - all of the sector names at Prestwick are proper names of places rather than just fixes/VORs, with the exception of 'South East', which is split into STAFA and TRENT sectors. I don't think we need a 'PC' qualifier before Prestwick sectors because none of the fully split names are duplicated at Swanwick.
For London AC sectors, we just have the sector number, because putting 'S' before it would be superfluous. I don't see a need to change this.
Then somehow at some point, we ended up with TC before the sector name for London TC, probably because when we didn't have the sectors fully split out, just NE for TC Northeast would've looked weird and is confusingly similar to our PC Northeast - and so the convention we've ended up with is having TCNE, TCRED, TCLAM, etc.
For that reason, until such time that we fully split out our TC sectors into their constituent parts, I suggest we continue to use the TC prefix - because NE or SW on its own is confusing! Eventually we could move to NEDEPS, SWDEPS, OCK, WILLO, TIMBA, but we're not there yet.
There was a problem hiding this comment.
That seems sensible, and I wouldn't oppose maintaining that status quo, though I don't think keeping "TCNE" and the like is necessarily incompatible with expanding the individual TC sector names.
Also, whilst we're tidying up the file names, might it be an idea to make consistent "Solent"/"SOLENT" and "13+14"/"E (13+14)"?
I'll do those others first once they're tested & approved. |
|
This PR won't re-order any agreements and break anything will it (@hazzas-99)? I think the alphabetical ordering of file names is important as ES does the first matching agreement it finds, and the compiler makes the .ese from the files in alphabetical order within folder order specified in the compiler config. |
@PLM1995 none of the files are excluded and then re-included in the config file and those are generally the ones that require specific ordering. Since we're just expanding abbreviations to their full form I should think the files will remain in almost exactly the same order otherwise! UK-Sector-File/compiler.config.json Lines 285 to 330 in f9e7135 |
|
@aidenbok203 you know you can stage multiple files for a single commit 😂 |
Fixes #5557