[WIP] Nearest Extreme Point Oracle variant #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
basically implements https://arxiv.org/pdf/2102.02029.pdf -> not done yet. need to change theory also to be more useful |
matbesancon
reviewed
Feb 14, 2021
| @@ -162,6 +163,14 @@ function fw( | |||
| (t, primal, primal - dual_gap, dual_gap, (time_ns() - time_start) / 1.0e9), | |||
| ) | |||
| end | |||
|
|
|||
| # build-in NEP here | |||
| if nep === true | |||
There was a problem hiding this comment.
Suggested change
| if nep === true | |
| if nep |
just checking the boolean directly
|
looking quickly at the paper, doesn't this need new LMOs? |
|
no for e.g., 0-1 problems or feasible regions with fixed norms as it can then be simulated via the LMO. see my implementation. This is actually quite smart as usually we would not pay any attention to „where“ we are but this one does. I can explain tomorrow.
Best,
Sebastian
…On 14. Feb 2021, 23:01 +0100, Mathieu Besançon ***@***.***>, wrote:
looking quickly at the paper, doesn't this need new LMOs?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Merged
|
@pokutta I think you have merged this into another branch that got merged into master, it is already there - it is not quite ready because of the interfacing as the gradient change depends on the iteration. i will fix it for vanilla FW today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.