Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added product LMO #97

Merged
merged 3 commits into from
Mar 1, 2021
Merged

added product LMO #97

merged 3 commits into from
Mar 1, 2021

Conversation

matbesancon
Copy link
Member

This introduces a LMO representing the cartesian product of N sets, with their corresponding LMOs

@pokutta
Copy link
Member

pokutta commented Feb 22, 2021

(super useful!!)

@matbesancon
Copy link
Member Author

@pokutta another interesting change on this PR:
all LMOs now accept all keyword arguments, and just pick the ones they use. This could be useful for #86, all LMOs could accept an argument nearest=true but just ignore it if it is not relevant for a given LMO

@pokutta
Copy link
Member

pokutta commented Feb 24, 2021

that's a very good idea!

@pokutta
Copy link
Member

pokutta commented Mar 1, 2021

this is conflicting now with the lp_norm code -> also if this is fine we should merge this

@matbesancon
Copy link
Member Author

I'll update the branch to merge it

@matbesancon matbesancon merged commit dd8e1d0 into master Mar 1, 2021
@matbesancon matbesancon deleted the lmo-product branch March 1, 2021 11:18
dhendryc pushed a commit that referenced this pull request Jan 17, 2025
@matbesancon
Merge pull request #97 from ZIB-IOL/lmo-product
e638e78 
added product LMO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matbesancon @pokutta