-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 changes of platform settings #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks okay. Would be better if we enrich error logs.
…pstack/unstract into feat/MultiTenancyV2-Platform-settings
Addressed All comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a NIT comment, others looks good.
Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: ali <[email protected]>
Co-authored-by: Chandrasekharan M <[email protected]> Signed-off-by: ali <[email protected]>
Please retry analysis of this Pull-Request directly on SonarCloud |
|
|
We can take care of duplication when we delete v1 eventually. Bypassing. |
What
Why
How
platform_auth_helper.py
to update the import statements from v2.platform_auth_service.py
to import from v2 applications and updated the methods of get_organization by using user context.serializers.py
to reflect import changes.apps.py
.views.py
for consistency with the new application structure.Changed files:
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
multi_tenancy_v2
.Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.