Overpressure - Separate backblast and overpressure range coefficient

[bluefieldcreator]

When merged this pull request will:

• Allow for backblast and overpressure distances to be configured individually

The original code forced all backblast and overpressure coefs to work together as one, meaning if you wanted the backblast of an RPG but not the overpressure of a tank firing, you just couldnt do it.

Now you can configure each individually through the range slider.

Notes: This is my first PR for SQF code & ACE ever, I'd appreciate all critcisim regarding the code and possible improvements.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[bluefieldcreator]

Ready for review.

[Drofseh]

Extra setting is good, but why move the config lookups?

I would do as follows

fnc_getOverPressureValues

_return = [
    (getNumber (_config >> QGVAR(angle))),
    (getNumber (_config >> QGVAR(range))),
    (getNumber (_config >> QGVAR(damage))),
    (getNumber (_config >> QGVAR(offset)))
];

fnc_firedEHBB

_bbValues params ["_backblastAngle", "_backblastRange", "_backblastDamage", "_offset"];
_backblastRange = _backblastRange * GVAR(backblastDistanceCoefficient);

fnc_firedEHOP

_opValues params ["_dangerZoneAngle", "_dangerZoneRange", "_dangerZoneDamage"];
_dangerZoneRange = _dangerZoneRange * GVAR(overpressureDistanceCoefficient);

[bluefieldcreator]

Extra setting is good, but why move the config lookups?

I would do as follows

fnc_getOverPressureValues

_return = [
    (getNumber (_config >> QGVAR(angle))),
    (getNumber (_config >> QGVAR(range))),
    (getNumber (_config >> QGVAR(damage))),
    (getNumber (_config >> QGVAR(offset)))
];

fnc_firedEHBB

_bbValues params ["_backblastAngle", "_backblastRange", "_backblastDamage", "_offset"];
_backblastRange = _backblastRange * GVAR(backblastDistanceCoefficient);

fnc_firedEHOP

_opValues params ["_dangerZoneAngle", "_dangerZoneRange", "_dangerZoneDamage"];
_dangerZoneRange = _dangerZoneRange * GVAR(overpressureDistanceCoefficient);

Exactly what I was trying to do, my brain was quite fried the other day so I just went the hardcoded way. I'll implement this.

[LinkIsGrim]

Probably want to change title to something like "separate backblast and overpressure range coefficient"

LGTM tho

[bluefieldcreator]

Thanks @LinkIsGrim

[PabstMirror]

• need to change xeh_postInit (lines 4 and 5)
• can remove ACE_Settings.hpp

[bluefieldcreator]

Will fix all this later today. Thanks for the reviews.

[bluefieldcreator]

Im gonna be honest, no clue what im doing with the stringtables lol

[johnb432]

Im gonna be honest, no clue what im doing with the stringtables lol

I'll try to take care of it.

[johnb432]

Do we want to add separate arsenal stats for overpressure? I imagine it's not necessary, given that infantry weapons usually don't create overpressure - or am I mistaken?

[LinkIsGrim]

They don't

[rautamiekka]

infantry weapons usually don't create overpressure

I know the Barrett 50cal creates some kinda backblast (as you could expect from needing a massive muzzle break and the heavy recoil mitigation for a stupidly powerful ammo like that) but dunno about overpressure nor the force of it. Currently the only indication of it in the game is the dust/sand.

[LinkIsGrim]

infantry weapons usually don't create overpressure

I know the Barrett 50cal creates some kinda backblast (as you could expect from needing a massive muzzle break and the heavy recoil mitigation for a stupidly powerful ammo like that) but dunno about overpressure nor the force of it. Currently the only indication of it in the game is the dust/sand.

Are you sure about that?

[Drofseh]

infantry weapons usually don't create overpressure

I know the Barrett 50cal creates some kinda backblast (as you could expect from needing a massive muzzle break and the heavy recoil mitigation for a stupidly powerful ammo like that) but dunno about overpressure nor the force of it. Currently the only indication of it in the game is the dust/sand.

Are you sure about that?

Rifles (especially with aggressive muzzle brakes or porting) can create uncomfortable conditions for those around them, but not to the degree of backblast/overpressure caused by launchers and cannons.

Many shooting ranges have mufflers like these to make shooting nicer for the people at the next station.

https://enoughgun.com/forum/download/file.php?id=4719&sid=c2eede1b5f90baab724bf9b8691273db

[bluefieldcreator]

infantry weapons usually don't create overpressure

I know the Barrett 50cal creates some kinda backblast (as you could expect from needing a massive muzzle break and the heavy recoil mitigation for a stupidly powerful ammo like that) but dunno about overpressure nor the force of it. Currently the only indication of it in the game is the dust/sand.

Are you sure about that?

Rifles (especially with aggressive muzzle brakes or porting) can create uncomfortable conditions for those around them, but not to the degree of backblast/overpressure caused by launchers and cannons.

Many shooting ranges have mufflers like these to make shooting nicer for the people at the next station.

https://enoughgun.com/forum/download/file.php?id=4719&sid=c2eede1b5f90baab724bf9b8691273db

It'd be cool, but im not too sure how I'd implement such setting, I am not familiar with the Arma 3 Config system.

On the other hand, I dont think it'd be used much, heavy weapon users do tend to be separated too mcuh for a feature like this to be worth noticing, whilist vehicle ovepressure is very noticeable if you are next to a tank.

[Drofseh]

It'd be cool, but im not too sure how I'd implement such setting

I dont think it'd be used much

Don't, it's not worth doing imo. I was just pointing out that rifles can have a certain amount of muzzle blast.

[johnb432]

In general looks good to me, but I'd ideally like to see the setting name reverted to what is was previously, instead of replacing it with a new one. Given nobody else from the ACE team has voiced their support for that, we'll leave it as it is atm.