Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension - Disable call context #10311

Closed
wants to merge 3 commits into from
Closed

Extension - Disable call context #10311

wants to merge 3 commits into from

Conversation

PabstMirror
Copy link
Contributor

Coming in 2.18 (and in profiling now)

10x "ace" callExtension ["break_line", ["alpha bravo charlie"]];

2.16: 0.251 ms
Profiling 2.16: 0.281 ms // call-context = true
Profiling 2.16: 0.221 ms // call-context = false
RC 2.18: 0.253 ms // call-context = true
RC 2.18: 0.215 ms // call-context = false

@PabstMirror PabstMirror added this to the 3.18.0 milestone Sep 12, 2024
@PabstMirror PabstMirror added the kind/optimization Release Notes: **IMPROVED:** label Sep 12, 2024
@BrettMayson
Copy link
Member

This won't do anything? That change to arma-rs would, but I have also started on an alternative PR for this

@PabstMirror
Copy link
Contributor Author

There is a measurable performance increase with this on 2.18 RC
You can see the RVExtensionFeatureFlags Export in the dll - https://www.virustotal.com/gui/file/2d138fc9012fe2eac385e798ac0538d3e344c69887db35f8ca1451f684149e12/details

@BrettMayson
Copy link
Member

BrettMayson commented Sep 12, 2024

Yes I know about that, but this PR won't do that, at least I don't think it should

This needs to be at the root of the crate, not within the init function

Did you build those DLLs with the different version of arma-rs

@PabstMirror
Copy link
Contributor Author

no change to cargo.toml, it's using 1.10.5

@BrettMayson
Copy link
Member

Ok yeah that's fine, TIL

This seems to be something that won't yell at you until you actually build a DLL. cargo check is fine with this conflicting, cargo build is not

@PabstMirror PabstMirror removed this from the 3.18.0 milestone Sep 17, 2024
@PabstMirror PabstMirror deleted the extNoCC branch September 17, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants