Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artillerytables - Fix Low shots & bad params #10325

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Sep 19, 2024

When merged this pull request will:

I didn't test how the bad params affected gameplay.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/bug-fix Release Notes: **FIXED:** ignore-changelog Release Notes: Excluded labels Sep 19, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Sep 19, 2024
@LinkIsGrim LinkIsGrim merged commit 3778747 into master Sep 20, 2024
8 checks passed
@LinkIsGrim LinkIsGrim deleted the artillerytables-fixes branch September 20, 2024 00:44
@johnb432
Copy link
Contributor Author

I forgot to update the extensions in the repository, but I'm not 100 % certain how to go about that.

@PabstMirror
Copy link
Contributor

cargo make release
u may have to install it first https://github.com/sagiegurari/cargo-make?tab=readme-ov-file#installation
if you use vscode, you can grab the https://github.com/acemod/ACE3/tree/master/tools/.vscode
and it will show under tasks

@johnb432
Copy link
Contributor Author

cargo make release u may have to install it first https://github.com/sagiegurari/cargo-make?tab=readme-ov-file#installation if you use vscode, you can grab the https://github.com/acemod/ACE3/tree/master/tools/.vscode and it will show under tasks

I managed to build the extension locally for testing, but I didn't quite understand which arguments to use. Thanks for the enlightenment, I believe to have understood it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artillery Tables: Low shots don't generate
3 participants