Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goggles - Add API to crack glasses #10648

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Conversation

DartRuffian
Copy link
Contributor

When merged this pull request will:

  • Add API function fnc_applyCrackEffect to crack a unit's goggles

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@DartRuffian
Copy link
Contributor Author

I'm open to editing some of the other existing goggles api if desired
I think it'd be nice to allow calling these functions on remote units (i.e. just passing a unit and targetEvent)

@LinkIsGrim LinkIsGrim modified the milestones: 3.18.3, 3.18.2 Jan 13, 2025
@LinkIsGrim LinkIsGrim merged commit a54c4da into acemod:master Jan 13, 2025
3 checks passed
@DartRuffian DartRuffian deleted the goggles/api branch January 13, 2025 21:20
PlayerBotPro pushed a commit to PlayerBotPro/ACE3 that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants