Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives - Optimise mine interaction code #10666

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.

Depending on how dense the mines are, just switching from allMines to nearestMines is >10x speedup. Switching from typeOf to configOf is 2x.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Jan 15, 2025
@LinkIsGrim LinkIsGrim added this to the 3.19.0 milestone Jan 16, 2025
@LinkIsGrim LinkIsGrim added the status/added-to-RC Added after RC, need to manually add to changelog label Jan 16, 2025
@PabstMirror PabstMirror merged commit 601c748 into master Jan 18, 2025
3 checks passed
@PabstMirror PabstMirror deleted the explosives-optimisation branch January 18, 2025 01:39
@PabstMirror PabstMirror removed the status/added-to-RC Added after RC, need to manually add to changelog label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants