-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field Rations - Improve and add setting for hunger/thirst consequence #10675
base: master
Are you sure you want to change the base?
Field Rations - Improve and add setting for hunger/thirst consequence #10675
Conversation
Fix unreachable water actions on vehicles with no waterActionOffset Allow water actions from within a vehicle with no waterActionOffset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two unrelated features being changed/added in this PR. Splitting it in two makes it easier to review (and therefore get merged), as well as having a more extensive changelog.
Make (or adjust #10171) for the interaction changes, whilst the consequence changes remain here (or vice versa).
Co-authored-by: johnb432 <[email protected]>
I'll make a new PR for the interaction improvements, as I might still use the old one for the item->magazine change that I was working on, but had left uncommitted. |
This reverts commit eb1a282.
When merged this pull request will:
Also fix the cooldown check, as*was already working, my changes broke it.CBA_missionTime > CBA_missionTime
could never be true.Add water actions directly to the vehicle instead of the helper object if the vehicle has no customMoved to Field Rations - Improve Vehicle Watersource Actions #10676."waterActionPosition"
.