-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mamba environment option #1370
Conversation
I will take a closer look after next week (am traveling). It was certainly available at the time of that PR, though |
So there used to be a |
# Import to make sure plugins are discoverable | ||
import asv.plugins.conda | ||
import asv.plugins.mamba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be required? (plugins are auto-discovered, failures mean they are dropped from valid options)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than explicitly raise from here the current approach is to not let mamba
be a valid option for an environment if the import fails.
The reason behind this is to allow for external plugins (it is also why we don't want to have an explicit list of allowed values).
but needs a newer Python version (3.8 or greater) and the ``libmambapy`` | ||
package must be installed to provide access to the mamba Python API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but needs a newer Python version (3.8 or greater) and the ``libmambapy`` | |
package must be installed to provide access to the mamba Python API. | |
but needs a newer Python version (3.8 or greater) and the ``libmambapy`` | |
package must be installed (typically through ``conda``) to provide access to the mamba Python API. |
Clarification since libmambapy
is not present on PyPI.
Fab, thanks for picking this up! |
I'm attempting to fix #1353. Currently this involves:
libmambapy
is installedmamba
plugin discoverable byasv
(by importing it inplugins.__init__.py
)However, I'm not convinced the mamba option has ever worked... The mamba Python API does not contain
mamba.api.MambaSolver()
, which was added as an import in #1238. @HaoZeke do you know any more about this import and what package needs to be installed to access it?